Changeset 30900 in vbox

Timestamp:

Jul 19, 2010 8:31:55 AM (15 years ago)

Author:

vboxsync

Message:

VMDK: Activate new async I/O by default

File:

• trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp

@@ -3941 +3941 @@
         if (!(uImageFlags & VD_IMAGE_FLAGS_FIXED))
         {
+            /* fPreAlloc should never be false because VMware can't use such images. */
             rc = vmdkCreateGrainDirectory(pExtent,
                                           RT_MAX(  pExtent->uDescriptorSector
                                                  + pExtent->cDescriptorSectors,
                                                  1),
-                                          true);
+                                          true /* fPreAlloc */);
             if (RT_FAILURE(rc))
                 return vmdkError(pImage, rc, RT_SRC_POS, N_("VMDK: could not create new grain directory in '%s'"), pExtent->pszFullname);
@@ -6474 +6475 @@
     PVMDKIMAGE pImage = (PVMDKIMAGE)pvBackendData;
 
-#if 1 /** @todo: Remove once the async support is tested throughly */
-    bool fAsyncIOSupported = false;
-
-    if (pImage)
-    {
-        fAsyncIOSupported = true;
-        for (unsigned i = 0; i < pImage->cExtents; i++)
-        {
-            if  (    pImage->pExtents[i].enmType != VMDKETYPE_FLAT
-                 &&  pImage->pExtents[i].enmType != VMDKETYPE_ZERO)
-            {
-                fAsyncIOSupported = false;
-                break; /* Stop search */
-            }
-        }
-    }
-
-    return fAsyncIOSupported;
-#else
     /* We do not support async I/O for stream optimized VMDK images. */
     return (pImage->uImageFlags & VD_VMDK_IMAGE_FLAGS_STREAM_OPTIMIZED) == 0;
-#endif
 }