Changeset 30902 in vbox

Timestamp:

Jul 19, 2010 9:02:40 AM (15 years ago)

Author:

vboxsync

Message:

GMMR0.cpp: Added log statements for some VERR_PGM_PHYS_INVALID_PAGE_ID failure (see #5124).

File:

• trunk/src/VBox/VMM/VMMR0/GMMR0.cpp (modified) (6 diffs)

trunk/src/VBox/VMM/VMMR0/GMMR0.cpp

@@ -3821 +3821 @@
  *
  * Performs the following tasks:
- * - if a shared page is new, then it changes the GMM page type to shared and returns it in the pPageDesc descriptor
- * - if a shared page already exists, then it checks if the VM page is identical and if so frees the VM page and returns the shared page in pPageDesc descriptor
- *
- * Note: assumes the caller has acquired the GMM semaphore!!
+ *  - If a shared page is new, then it changes the GMM page type to shared and
+ *    returns it in the pPageDesc descriptor.
+ *  - If a shared page already exists, then it checks if the VM page is
+ *    identical and if so frees the VM page and returns the shared page in
+ *    pPageDesc descriptor.
+ *
+ * @remarks ASSUMES the caller has acquired the GMM semaphore!!
  *
  * @returns VBox status code.
@@ -3834 +3837 @@
  * @param   paPageDesc          Page descriptor
  */
-GMMR0DECL(int) GMMR0SharedModuleCheckPage(PGVM pGVM, PGMMSHAREDMODULE pModule, unsigned idxRegion, unsigned idxPage, PGMMSHAREDPAGEDESC pPageDesc)
+GMMR0DECL(int) GMMR0SharedModuleCheckPage(PGVM pGVM, PGMMSHAREDMODULE pModule, unsigned idxRegion, unsigned idxPage,
+                                          PGMMSHAREDPAGEDESC pPageDesc)
 {
     int rc = VINF_SUCCESS;
@@ -3873 +3877 @@
         if (!pPage)
         {
+            Log(("GMMR0SharedModuleCheckPage: Invalid idPage=%#x #1 (GCPhys=%RGp HCPhys=%RHp idxRegion=%#x idxPage=%#x)\n",
+                 pPageDesc->uHCPhysPageId, pPageDesc->GCPhys, pPageDesc->HCPhys, idxRegion, idxPage));
             AssertFailed();
             rc = VERR_PGM_PHYS_INVALID_PAGE_ID;
@@ -3899 +3905 @@
         if (!pPage)
         {
+            Log(("GMMR0SharedModuleCheckPage: Invalid idPage=%#x #2 (idxRegion=%#x idxPage=%#x)\n",
+                 pPageDesc->uHCPhysPageId, idxRegion, idxPage));
             AssertFailed();
             rc = VERR_PGM_PHYS_INVALID_PAGE_ID;
@@ -3920 +3928 @@
             if (!gmmR0IsChunkMapped(pGVM, pChunk, (PRTR3PTR)&pbChunk))
             {
+                Log(("GMMR0SharedModuleCheckPage: Invalid idPage=%#x #3\n", pPageDesc->uHCPhysPageId));
                 AssertFailed();
                 rc = VERR_PGM_PHYS_INVALID_PAGE_ID;
@@ -3928 +3937 @@
         else
         {
+            Log(("GMMR0SharedModuleCheckPage: Invalid idPage=%#x #4\n", pPageDesc->uHCPhysPageId));
             AssertFailed();
             rc = VERR_PGM_PHYS_INVALID_PAGE_ID;