Changeset 3093 in vbox

Timestamp:

Jun 11, 2007 4:36:47 PM (18 years ago)

Author:

vboxsync

Message:

Hack around incomprehensible VDI error message for VMDK files that fail
to open for any reason (most popular is access problems).

File:

• trunk/src/VBox/Main/HardDiskImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/HardDiskImpl.cpp

@@ -1069 +1069 @@
 
     HardDiskStorageType_T order [2];
+    size_t cOrder = ELEMENTS (order);
 
     if (RTPathCompare (ext, ".vmdk") == 0)
     {
+        /// @todo This is a hack. The proper solution would be to save the
+        /// error info from the first try and restore that if everything fails.
+        /// That way a non-working VMDK will get a proper VMDK diagnostics
+        /// message and not some incomprehensible VDI error.
         order [0] = HardDiskStorageType_VMDKImage;
-        order [1] = HardDiskStorageType_VirtualDiskImage;
+        cOrder = 1;
     }
     else
@@ -1081 +1086 @@
     }
 
-    for (size_t i = 0; i < ELEMENTS (order); ++ i)
+    for (size_t i = 0; i < cOrder; ++ i)
     {
         switch (order [i])