Changeset 30931 in vbox

Timestamp:

Jul 20, 2010 3:05:18 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

63799

Message:

Main/OVF: add testcase for host-specific audio drivers

Location:

trunk/src/VBox/Main

Files:

• MachineImpl.cpp (modified) (3 diffs)
• testcase/Makefile.kmk (modified) (1 diff)
• testcase/tstOVF.cpp (modified) (2 diffs)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -6021 +6021 @@
     if (fCloseMedia)
     {
+        // call backup before iterating over the media, because backup WILL change
+        // the pointers and invalidate iterators (grrrrr)
+        setModified(IsModified_Storage);
+        mMediaData.backup();         // do not call this or iterators will be invalidated
+
         // caller wants automatic detachment: then do that and report all media to the array
         MediaData::AttachmentList::iterator it = mMediaData->mAttachments.begin();
@@ -6030 +6035 @@
             if (!pMedium.isNull())
                 llMedia.push_back(pMedium);
-
-            setModified(IsModified_Storage);
-            mMediaData.backup();
 
             // for non-hard disk media, detach straight away
@@ -6039 +6041 @@
                 pMedium->detachFrom(mData->mUuid);
 
-            // remove this attachment; erase() returns the iterator of the next element
+            // remove this attachment; erase() returns the iterator behind the thing that got deleted
             it = mMediaData->mAttachments.erase(it);
-        }
+        };
     }
     else

trunk/src/VBox/Main/testcase/Makefile.kmk

@@ -93 +93 @@
         ovf-dummy.vmdk \
         ovf-joomla-0.9/joomla-1.1.4-ovf.ovf=>ovf-joomla-0.9/joomla-1.1.4-ovf.ovf \
+        ovf-winhost-audio-nodisks/WinXP.ovf=>ovf-winhost-audio-nodisks/WinXP.ovf \
         ovf-winxp-vbox-sharedfolders/winxp.ovf=>ovf-winxp-vbox-sharedfolders/winxp.ovf
 endif

trunk/src/VBox/Main/testcase/tstOVF.cpp

@@ -309 +309 @@
         EventQueue eventQ;
 
+        // for each testcase, we will copy the dummy VMDK image to the subdirectory with the OVF testcase
+        // so that the import will find the disks it expects; this is just for testing the import since
+        // the imported machines will obviously not be usable.
+        // llFiles2Delete receives the paths of all the files that we need to clean up later.
+
         // testcase 1: import ovf-joomla-0.9/joomla-1.1.4-ovf.ovf
         copyDummyDiskImage("joomla-0.9", llFiles2Delete, "ovf-testcases/ovf-joomla-0.9/joomla-1.1.4-ovf-0.vmdk");
@@ -318 +323 @@
         copyDummyDiskImage("winxp-vbox-sharedfolders", llFiles2Delete, "ovf-testcases/ovf-winxp-vbox-sharedfolders/smallvdi.vmdk");
         importOVF("winxp-vbox-sharedfolders", pVirtualBox, "ovf-testcases/ovf-winxp-vbox-sharedfolders/winxp.ovf", llMachinesCreated);
+
+        // testcase 3: import ovf-winxp-vbox-sharedfolders/winxp.ovf
+        importOVF("winhost-audio-nodisks", pVirtualBox, "ovf-testcases/ovf-winhost-audio-nodisks/WinXP.ovf", llMachinesCreated);
 
         RTPrintf("Machine imports done, no errors. Cleaning up...\n");