Changeset 30950 in vbox

Timestamp:

Jul 21, 2010 11:36:18 AM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

63838

Message:

Main: use settings::SystemProperties in SystemPropertiesImpl.h

Location:

trunk/src/VBox/Main

Files:

• SystemPropertiesImpl.cpp (modified) (18 diffs)
• VirtualBoxImpl.cpp (modified) (3 diffs)
• include/SystemPropertiesImpl.h (modified) (1 diff)

trunk/src/VBox/Main/SystemPropertiesImpl.cpp

@@ -43 +43 @@
 
 SystemProperties::SystemProperties()
-    : mParent(NULL)
+    : mParent(NULL),
+      m(new settings::SystemProperties)
 {
 }
@@ -49 +50 @@
 SystemProperties::~SystemProperties()
 {
+    delete m;
 }
 
@@ -88 +90 @@
     setRemoteDisplayAuthLibrary(Utf8Str::Null);
 
-    mLogHistoryCount = 3;
+    m->ulLogHistoryCount = 3;
 
     HRESULT rc = S_OK;
@@ -112 +114 @@
             if (FAILED(rc)) break;
 
-            mMediumFormats.push_back(hdf);
+            m_llMediumFormats.push_back(hdf);
         }
     }
@@ -577 +579 @@
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    SafeIfaceArray<IMediumFormat> mediumFormats(mMediumFormats);
+    SafeIfaceArray<IMediumFormat> mediumFormats(m_llMediumFormats);
     mediumFormats.detachTo(ComSafeArrayOutArg(aMediumFormats));
 
@@ -592 +594 @@
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    m_strDefaultHardDiskFormat.cloneTo(aDefaultHardDiskFormat);
+    m->strDefaultHardDiskFormat.cloneTo(aDefaultHardDiskFormat);
 
     return S_OK;
@@ -673 +675 @@
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    m_strRemoteDisplayAuthLibrary.cloneTo(aRemoteDisplayAuthLibrary);
+    m->strRemoteDisplayAuthLibrary.cloneTo(aRemoteDisplayAuthLibrary);
 
     return S_OK;
@@ -706 +708 @@
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    m_strWebServiceAuthLibrary.cloneTo(aWebServiceAuthLibrary);
+    m->strWebServiceAuthLibrary.cloneTo(aWebServiceAuthLibrary);
 
     return S_OK;
@@ -739 +741 @@
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    *count = mLogHistoryCount;
+    *count = m->ulLogHistoryCount;
 
     return S_OK;
@@ -750 +752 @@
 
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
-    mLogHistoryCount = count;
+    m->ulLogHistoryCount = count;
     alock.release();
 
@@ -801 +803 @@
     if (FAILED(rc)) return rc;
 
-    mLogHistoryCount = data.ulLogHistoryCount;
+    m->ulLogHistoryCount = data.ulLogHistoryCount;
 
     return S_OK;
@@ -813 +815 @@
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    data.strDefaultMachineFolder = m_strDefaultMachineFolder;
-    data.strDefaultHardDiskFolder = m_strDefaultHardDiskFolder;
-    data.strDefaultHardDiskFormat = m_strDefaultHardDiskFormat;
-    data.strRemoteDisplayAuthLibrary = m_strRemoteDisplayAuthLibrary;
-    data.strWebServiceAuthLibrary = m_strWebServiceAuthLibrary;
-    data.ulLogHistoryCount = mLogHistoryCount;
+    data = *m;
 
     return S_OK;
@@ -840 +837 @@
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    for (MediumFormatList::const_iterator it = mMediumFormats.begin();
-         it != mMediumFormats.end(); ++ it)
+    for (MediumFormatList::const_iterator it = m_llMediumFormats.begin();
+         it != m_llMediumFormats.end();
+         ++ it)
     {
         /* MediumFormat is all const, no need to lock */
@@ -873 +871 @@
                         vrc);
 
-    m_strDefaultMachineFolder = path;
+    m->strDefaultMachineFolder = path;
     m_strDefaultMachineFolderFull = folder;
 
@@ -894 +892 @@
                         vrc);
 
-    m_strDefaultHardDiskFolder = path;
+    m->strDefaultHardDiskFolder = path;
     m_strDefaultHardDiskFolderFull = folder;
 
@@ -903 +901 @@
 {
     if (!aFormat.isEmpty())
-        m_strDefaultHardDiskFormat = aFormat;
+        m->strDefaultHardDiskFormat = aFormat;
     else
-        m_strDefaultHardDiskFormat = "VDI";
+        m->strDefaultHardDiskFormat = "VDI";
 
     return S_OK;
@@ -913 +911 @@
 {
     if (!aPath.isEmpty())
-        m_strRemoteDisplayAuthLibrary = aPath;
+        m->strRemoteDisplayAuthLibrary = aPath;
     else
-        m_strRemoteDisplayAuthLibrary = "VRDPAuth";
+        m->strRemoteDisplayAuthLibrary = "VRDPAuth";
 
     return S_OK;
@@ -923 +921 @@
 {
     if (!aPath.isEmpty())
-        m_strWebServiceAuthLibrary = aPath;
+        m->strWebServiceAuthLibrary = aPath;
     else
-        m_strWebServiceAuthLibrary = "VRDPAuth";
-
-    return S_OK;
-}
-
+        m->strWebServiceAuthLibrary = "VRDPAuth";
+
+    return S_OK;
+}
+

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -3202 +3202 @@
 {
     AutoReadLock propsLock(m->pSystemProperties COMMA_LOCKVAL_SRC_POS);
-    return m->pSystemProperties->m_strDefaultMachineFolder;
+    return m->pSystemProperties->m->strDefaultMachineFolder;
 }
 
@@ -3213 +3213 @@
 {
     AutoReadLock propsLock(m->pSystemProperties COMMA_LOCKVAL_SRC_POS);
-    return m->pSystemProperties->m_strDefaultHardDiskFolder;
+    return m->pSystemProperties->m->strDefaultHardDiskFolder;
 }
 
@@ -3224 +3224 @@
 {
     AutoReadLock propsLock(m->pSystemProperties COMMA_LOCKVAL_SRC_POS);
-    return m->pSystemProperties->m_strDefaultHardDiskFormat;
+    return m->pSystemProperties->m->strDefaultHardDiskFormat;
 }
 

trunk/src/VBox/Main/include/SystemPropertiesImpl.h

@@ -125 +125 @@
     VirtualBox * const  mParent;
 
-    Utf8Str             m_strDefaultMachineFolder;
+    settings::SystemProperties *m;
+
     Utf8Str             m_strDefaultMachineFolderFull;
-    Utf8Str             m_strDefaultHardDiskFolder;
     Utf8Str             m_strDefaultHardDiskFolderFull;
-    Utf8Str             m_strDefaultHardDiskFormat;
 
-    MediumFormatList    mMediumFormats;
-
-    Utf8Str             m_strRemoteDisplayAuthLibrary;
-    Utf8Str             m_strWebServiceAuthLibrary;
-    ULONG               mLogHistoryCount;
+    MediumFormatList    m_llMediumFormats;
 
     friend class VirtualBox;