Changeset 30966 in vbox

Timestamp:

Jul 21, 2010 2:20:20 PM (15 years ago)

Author:

vboxsync

Message:

VBoxServiceVMInfo.cpp: r=bird: bad stuff.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo.cpp

@@ -258 +258 @@
             cUtmpEntries++;
     }
+    /** @todo r=bird: Guess what happens if someone logs in right now.
+     *        Better do all in a single loop and dynamically resize arrays. */
 
     if (cUtmpEntries) /* Do we have some users at all? */
@@ -278 +280 @@
 
                     if (!fFound)
+/** @todo r=bird: RTStrAAppend on an uninitailized variable. Didn't use
+ *        RTMemAllocZ!. */
                         rc = RTStrAAppend(&aUsers[cUsersInList++], (const char*)ut_user->ut_user);
                 }