Changeset 31243 in vbox for trunk

Timestamp:

Jul 30, 2010 1:10:33 PM (14 years ago)

Author:

vboxsync

Message:

Storage/iSCSI: optimize changing the open flags from read/write to readonly

File:

• trunk/src/VBox/Devices/Storage/ISCSIHDDCore.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/ISCSIHDDCore.cpp

@@ -3785 +3785 @@
     }
 
-    /* Implement this operation via reopening the image. */
-    iscsiFreeImage(pImage, false);
-    rc = iscsiOpenImage(pImage, uOpenFlags);
-
+    /* Implement this operation via reopening the image if we actually need
+     * to do something. A read/write -> readonly transition doesn't need a
+     * reopen. In the other direction we don't have the necessary information
+     * as the "disk is readonly" flag is thrown away. Can be optimized too,
+     * but it's not worth the effort at the moment. */
+    if (   !(uOpenFlags & VD_OPEN_FLAGS_READONLY)
+        && (pImage->uOpenFlags & VD_OPEN_FLAGS_READONLY))
+    {
+        iscsiFreeImage(pImage, false);
+        rc = iscsiOpenImage(pImage, uOpenFlags);
+    }
+    else
+    {
+        pImage->uOpenFlags = uOpenFlags;
+        rc = VINF_SUCCESS;
+    }
 out:
     LogFlowFunc(("returns %Rrc\n", rc));