Changeset 31262 in vbox

Timestamp:

Jul 31, 2010 8:49:57 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

64285

Message:

VBoxHeadless.cpp: Revised fix: Don't use WaitForCompletion() at all, just poll IProgress::Completed.

File:

• trunk/src/VBox/Frontends/VBoxHeadless/VBoxHeadless.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxHeadless/VBoxHeadless.cpp

@@ -1075 +1075 @@
         CHECK_ERROR_BREAK(console, PowerUp(progress.asOutParam()));
 
-        /* wait for result because there can be errors */
-        /** @todo The error handling here is kind of peculiar, anyone care
-         *        to comment why this works just fine? */
+        /*
+         * Wait for the result because there can be errors.
+         *
+         * It's vital to process events while waiting (teleportation deadlocks),
+         * so we'll poll for the completion instead of waiting on it.
+         */
         for (;;)
         {
-            rc = progress->WaitForCompletion(500);
-            if (FAILED(rc))
-                break;
-
-            /* Processing events is vital for teleportation targets. */
-            gEventQ->processEventQueue(0);
-
             BOOL fCompleted;
             rc = progress->COMGETTER(Completed)(&fCompleted);
             if (FAILED(rc) || fCompleted)
                 break;
-        }
-
+
+            /* Process pending events, then wait for new ones. */
+            gEventQ->processEventQueue(0);
+            gEventQ->processEventQueue(500);
+        }
+
+        /** @todo The error handling here is kind of peculiar, anyone care
+         *        to comment why this works just fine? (this is old the code) */
         if (SUCCEEDED(progress->WaitForCompletion(-1)))
         {