Changeset 31296 in vbox for trunk/src/VBox/Main/include

Timestamp:

Aug 2, 2010 1:13:14 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

64323

Message:

Main: cleanup host drives management: do not return different IMedium objects every time Host::GetDVDDrives() or HOst::GetFloppyDrives() are called; refresh the internal list only when a public API is called, but not for every single internal use such as loading machine settings file; fix code duplication

Location:

trunk/src/VBox/Main/include

Files:

• HostImpl.h (modified) (2 diffs)
• VirtualBoxImpl.h (modified) (1 diff)

trunk/src/VBox/Main/include/HostImpl.h

@@ -108 +108 @@
     HRESULT saveSettings(settings::Host &data);
 
-    HRESULT getDVDDrives(MediaList &ll);
-    HRESULT getFloppyDrives(MediaList &ll);
+    HRESULT getDrives(DeviceType_T mediumType, bool fRefresh, MediaList *&pll);
+    HRESULT findHostDrive(DeviceType_T mediumType, const Guid &uuid, bool fRefresh, ComObjPtr<Medium> &pMedium);
 
 #ifdef VBOX_WITH_USB
@@ -127 +127 @@
 
 private:
+
+    HRESULT buildDVDDrivesList(MediaList &list);
+    HRESULT buildFloppyDrivesList(MediaList &list);
 
 #if defined(RT_OS_SOLARIS) && defined(VBOX_USE_LIBHAL)

trunk/src/VBox/Main/include/VirtualBoxImpl.h

@@ -228 +228 @@
                                  bool aSetError,
                                  ComObjPtr<Medium> *aImage = NULL);
+    HRESULT findRemoveableMedium(DeviceType_T mediumType,
+                                 const Guid &uuid,
+                                 bool fRefresh,
+                                 ComObjPtr<Medium> &pMedium);
 
     HRESULT findGuestOSType(const Bstr &bstrOSType,