Changeset 31313 in vbox for trunk

Timestamp:

Aug 2, 2010 3:19:38 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

64340

Message:

Main: fix memory leak in error path

File:

• trunk/src/VBox/Main/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -3420 +3420 @@
                                         medium,
                                         *pMediumLockList);
-        if (FAILED(rc)) return rc;
-        rc = pMediumLockList->Lock();
-        if (FAILED(rc))
-            return setError(rc,
-                            tr("Could not lock medium when creating diff '%s'"),
-                            diff->getLocationFull().c_str());
-
-        /* will leave the lock before the potentially lengthy operation, so
-         * protect with the special state */
-        MachineState_T oldState = mData->mMachineState;
-        setMachineState(MachineState_SettingUp);
-
-        mediumLock.leave();
-        treeLock.leave();
-        alock.leave();
-
-        rc = medium->createDiffStorage(diff,
-                                       MediumVariant_Standard,
-                                       pMediumLockList,
-                                       NULL /* aProgress */,
-                                       true /* aWait */,
-                                       &fNeedsSaveSettings);
-
-        alock.enter();
-        treeLock.enter();
-        mediumLock.enter();
-
-        setMachineState(oldState);
+        if (SUCCEEDED(rc))
+        {
+            rc = pMediumLockList->Lock();
+            if (FAILED(rc))
+                setError(rc,
+                         tr("Could not lock medium when creating diff '%s'"),
+                         diff->getLocationFull().c_str());
+            else
+            {
+                /* will leave the lock before the potentially lengthy operation, so
+                 * protect with the special state */
+                MachineState_T oldState = mData->mMachineState;
+                setMachineState(MachineState_SettingUp);
+
+                mediumLock.leave();
+                treeLock.leave();
+                alock.leave();
+
+                rc = medium->createDiffStorage(diff,
+                                               MediumVariant_Standard,
+                                               pMediumLockList,
+                                               NULL /* aProgress */,
+                                               true /* aWait */,
+                                               &fNeedsSaveSettings);
+
+                alock.enter();
+                treeLock.enter();
+                mediumLock.enter();
+
+                setMachineState(oldState);
+            }
+        }
 
         /* Unlock the media and free the associated memory. */