Changeset 31344 in vbox for trunk/src/VBox

Timestamp:

Aug 3, 2010 3:58:25 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

64383

Message:

Main: Machine::Delete(): move saveSettings() to worker thread

File:

• trunk/src/VBox/Main/MachineImpl.cpp (modified) (6 diffs)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -4090 +4090 @@
     std::list<Utf8Str>          llFilesToDelete;
     ComObjPtr<Progress>         pProgress;
+    bool                        fNeedsGlobalSaveSettings;
 };
 
@@ -4100 +4101 @@
 
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
-
-    bool fNeedsGlobalSaveSettings = false;
 
     HRESULT rc = checkStateDependency(MutableStateDep);
@@ -4116 +4115 @@
     // collect files to delete
     pTask->llFilesToDelete = mData->llFilesToDelete;            // saved states pushed here by Unregister()
+
+    pTask->fNeedsGlobalSaveSettings = false;
     for (size_t i = 0; i < sfaMedia.size(); ++i)
     {
@@ -4126 +4127 @@
         // close the medium now; if that succeeds, then that means the medium is no longer
         // in use and we can add it to the list of files to delete
-        rc = pMedium->close(&fNeedsGlobalSaveSettings, mediumAutoCaller);
+        rc = pMedium->close(&pTask->fNeedsGlobalSaveSettings,
+                            mediumAutoCaller);
         if (SUCCEEDED(rc))
             pTask->llFilesToDelete.push_back(bstrLocation);
@@ -4150 +4152 @@
 
     pTask->pProgress.queryInterfaceTo(aProgress);
-
-    alock.release();
-
-    if (fNeedsGlobalSaveSettings)
-    {
-        AutoWriteLock vboxlock(mParent COMMA_LOCKVAL_SRC_POS);
-        mParent->saveSettings();
-    }
 
     if (RT_FAILURE(vrc))
@@ -4296 +4290 @@
                 RTDirRemove(settingsDir.c_str());
         }
+    }
+
+    alock.release();
+
+    if (task.fNeedsGlobalSaveSettings)
+    {
+        AutoWriteLock vboxlock(mParent COMMA_LOCKVAL_SRC_POS);
+        mParent->saveSettings();
     }