Changeset 31347 in vbox

Timestamp:

Aug 4, 2010 8:17:58 AM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

64388

Message:

HDA: Review notes.

Location:

trunk/src/VBox/Devices/Audio

Files:

• DevCodec.cpp (modified) (2 diffs)
• DevIchIntelHDA.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DevCodec.cpp

@@ -928 +928 @@
         dac_init:
             memset(pNode->dac.B_params, 0, AMPLIFIER_SIZE);
+            //** @todo r=michaln: 0x2 in the low bits means 3 channels, not 2??
             pNode->dac.u32A_param = RT_BIT(14)|(0x1 << 4)|0x2; /* 441000Hz/16bit/2ch */
 
@@ -946 +947 @@
             pNode->node.au8F02_param[0] = 0x18;
         adc_init:
+            //** @todo r=michaln: Shouldn't that be (0x1 << 4)? Same problem with no. of channels.
             pNode->adc.u32A_param = RT_BIT(14)|(0x1 << 3)|0x2; /* 441000Hz/16bit/2ch */
             pNode->adc.node.au32F00_param[0xE] = RT_BIT(0);

trunk/src/VBox/Devices/Audio/DevIchIntelHDA.cpp

@@ -1173 +1173 @@
         temp    -= copied;
         written += copied;
+        //** @todo r=michaln: Should that be '+= written' or '+= copied?'
         pState->u32CviPos += written;
     }
@@ -1199 +1200 @@
                 || avail == 0)
                 return;
+            //** @todo r=michaln: Why is that 'adc' and not 'dac'? Why is the mask 0x5 and not 0xf?
             SDCTL(pState, 4) |= ((pState->Codec.pNodes[2].adc.u32F06_param & (0x5 << 4)) >> 4) << 20;
             fetch_bd(pState);