Changeset 31377 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Aug 5, 2010 3:01:03 AM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

64434

Message:

Audio/HDA: some todo and clean up.

File:

• trunk/src/VBox/Devices/Audio/DevIchIntelHDA.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DevIchIntelHDA.cpp

@@ -1173 +1173 @@
         temp    -= copied;
         written += copied;
-        //** @todo r=michaln: Should that be '+= written' or '+= copied?'
-        pState->u32CviPos += written;
+        pState->u32CviPos += copied;
     }
     return written;
@@ -1200 +1199 @@
                 || avail == 0)
                 return;
-            //** @todo r=michaln: Why is that 'adc' and not 'dac'? Why is the mask 0x5 and not 0xf?
-            SDCTL(pState, 4) |= ((pState->Codec.pNodes[2].adc.u32F06_param & (0x5 << 4)) >> 4) << 20;
+            SDCTL(pState, 4) |= ((pState->Codec.pNodes[2].dac.u32F06_param & (0xf << 4)) >> 4) << 20;
             fetch_bd(pState);
             while(   avail
@@ -1237 +1235 @@
                                 pState->u32Cvi = 0;
                         }
-                     }
+                    }
                 }
                 fetch_bd(pState);