Changeset 31445 in vbox

Timestamp:

Aug 7, 2010 9:12:46 PM (14 years ago)

Author:

vboxsync

Message:

PGMRZDynMap.cpp: Unused hinting debugging, define PGMRZDYNMAP_STRICT_RELEASE to enable it (disabled by default).

File:

• trunk/src/VBox/VMM/VMMRZ/PGMRZDynMap.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMRZ/PGMRZDynMap.cpp

@@ -146 +146 @@
         (pEntry)->cUnrefs      = 0; \
     } while (0)
+
+
+/** @def PGMRZDYNMAP_STRICT_RELEASE
+ * Define this to force pages to be released and make non-present ASAP after
+ * use.  This should not normally be enabled as it is a bit expensive. */
+#if 0 || defined(DOXYGEN_RUNNING)
+# define PGMRZDYNMAP_STRICT_RELEASE
+#endif
 
 
@@ -1312 +1320 @@
     AssertMsg(cRefs >= 0, ("%d\n", cRefs));
     if (!cRefs)
+    {
         pThis->cLoad--;
+#ifdef PGMRZDYNMAP_STRICT_RELEASE
+        pThis->paPages[iPage].HCPhys = NIL_RTHCPHYS;
+        ASMAtomicBitClear(pThis->paPages[iPage].uPte.pv, X86_PTE_BIT_P);
+        ASMInvalidatePage(pThis->paPages[iPage].pvPage);
+#endif
+    }
 }
 
@@ -1615 +1630 @@
                     cLoad++;
             }
-#ifdef IN_RING0
+#if defined(IN_RING0) && !defined(PGMRZDYNMAP_STRICT_RELEASE)
             else
                 CHECK_RET(paPages[iPage].uPte.pLegacy->u == paSavedPTEs[iPage],
@@ -2142 +2157 @@
      * Find the entry in the usual unrolled fashion.
      */
+    /** @todo add a hint to the set which entry was used last since it's not
+     *        always the last entry? */
 #define IS_MATCHING_ENTRY(pSet, iEntry, pvHint) \
         (   (pSet)->aEntries[(iEntry)].pvPage == (pvHint) \
@@ -2215 +2232 @@
     else
         Log(("pgmRZDynMapUnusedHint: pvHint=%p ignored because of overflow! %s(%d) %s\n", pvHint, pszFile, iLine, pszFunction));
+
+#ifdef PGMRZDYNMAP_STRICT_RELEASE
+    /*
+     * Optimize the set to trigger the unmapping and invalidation of the page.
+     */
+    if (cUnrefs + 1 == cTotalRefs)
+        pgmDynMapOptimizeAutoSet(pSet);
+#endif
 }