Changeset 31745 in vbox for trunk/src/VBox/Main

Timestamp:

Aug 18, 2010 9:44:22 AM (14 years ago)

Author:

vboxsync

Message:

Guest::setSupportedFeatures should take uint32_t arguments not (U)LONG64.

Location:

trunk/src/VBox/Main

Files:

• GuestImpl.cpp (modified) (2 diffs)
• VMMDevInterface.cpp (modified) (1 diff)
• include/GuestImpl.h (modified) (1 diff)

trunk/src/VBox/Main/GuestImpl.cpp

@@ -1555 +1555 @@
  * Sets the supported features (and whether they are active or not).
  *
- * @param ulCaps
- * @param ulActive
+ * @param   fCaps       Guest capability bit mask (VMMDEV_GUEST_SUPPORTS_XXX).
+ * @param   fActive     No idea what this is supposed to be, it's always 0 and
+ *                      not references by this method.
  */
-void Guest::setSupportedFeatures(LONG64 ulCaps, LONG64 ulActive)
+void Guest::setSupportedFeatures(uint32_t fCaps, uint32_t fActive)
 {
     AutoCaller autoCaller(this);
@@ -1565 +1566 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    mData.mSupportsSeamless = (ulCaps & VMMDEV_GUEST_SUPPORTS_SEAMLESS);
+    mData.mSupportsSeamless = (fCaps & VMMDEV_GUEST_SUPPORTS_SEAMLESS);
     /** @todo Add VMMDEV_GUEST_SUPPORTS_GUEST_HOST_WINDOW_MAPPING */
-    mData.mSupportsGraphics = (ulCaps & VMMDEV_GUEST_SUPPORTS_GRAPHICS);
+    mData.mSupportsGraphics = (fCaps & VMMDEV_GUEST_SUPPORTS_GRAPHICS);
 }
 /* vi: set tabstop=4 shiftwidth=4 expandtab: */

trunk/src/VBox/Main/VMMDevInterface.cpp

@@ -300 +300 @@
      * Report our current capabilites (and assume none is active yet).
      */
-    guest->setSupportedFeatures((ULONG64)newCapabilities, 0 /* Active capabilities, not used here. */);
+    guest->setSupportedFeatures(newCapabilities, 0 /* Active capabilities, not used here. */);
 
     /*

trunk/src/VBox/Main/include/GuestImpl.h

@@ -110 +110 @@
     void setAdditionsInfo2(Bstr aAdditionsVersion, Bstr aVersionName, Bstr aRevision);
     void setAdditionsStatus(VBoxGuestStatusFacility Facility, VBoxGuestStatusCurrent Status, ULONG ulFlags);
-    void setSupportedFeatures(LONG64 ulCaps, LONG64 ulActive);
+    void setSupportedFeatures(uint32_t fCaps, uint32_t fActive);
     HRESULT setStatistic(ULONG aCpuId, GUESTSTATTYPE enmType, ULONG aVal);
     BOOL isPageFusionEnabled();