Changeset 31746 in vbox

Timestamp:

Aug 18, 2010 10:08:52 AM (14 years ago)

Author:

vboxsync

Message:

Main: Added input validations missing in r64842.

Location:

trunk/src/VBox/Main

Files:

• GuestImpl.cpp (modified) (1 diff)
• MachineImpl.cpp (modified) (1 diff)
• MediumImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/GuestImpl.cpp

@@ -1225 +1225 @@
 
     CheckComArgExpr(aPID, aPID > 0);
-
+    if (aSize < 0)
+        return setError(E_INVALIDARG, tr("The size argument (%lld) is negative"), aSize);
     if (aFlags != 0) /* Flags are not supported at the moment. */
-        return E_INVALIDARG;
+        return setError(E_INVALIDARG, tr("Unknown flags (%#x)"), aFlags);
 
     AutoCaller autoCaller(this);

trunk/src/VBox/Main/MachineImpl.cpp

@@ -5620 +5620 @@
     LogFlowThisFunc(("\n"));
     CheckComArgOutSafeArrayPointerValid(aData);
+    if (aSize < 0)
+        return setError(E_INVALIDARG, tr("The size argument (%lld) is negative"), aSize);
 
     AutoCaller autoCaller(this);

trunk/src/VBox/Main/MediumImpl.cpp

@@ -2131 +2131 @@
 {
     CheckComArgOutPointerValid(aProgress);
+    if (aLogicalSize < 0)
+        return setError(E_INVALIDARG, tr("The medium size argument (%lld) is negative"), aLogicalSize);
 
     AutoCaller autoCaller(this);