Changeset 31869 in vbox for trunk/src

Timestamp:

Aug 23, 2010 3:22:50 PM (14 years ago)

Author:

vboxsync

Message:

coredumper-solaris.cpp: RTFileGetSize returns uint64_t and this cannot be safely cast to size_t! Please fix.

File:

• trunk/src/VBox/Runtime/r3/solaris/coredumper-solaris.cpp (modified) (5 diffs)

trunk/src/VBox/Runtime/r3/solaris/coredumper-solaris.cpp

@@ -78 +78 @@
 
 
-/** 
- * Wrapper function to write IPRT format style string to the syslog. 
- * 
- * @param pszFormat         Format string 
+/**
+ * Wrapper function to write IPRT format style string to the syslog.
+ *
+ * @param pszFormat         Format string
  */
 static void rtCoreDumperSysLogWrapper(const char *pszFormat, ...)
@@ -199 +199 @@
 static size_t GetFileSize(const char *pszPath)
 {
-    size_t cb = 0;
+    uint64_t cb = 0;
     RTFILE hFile;
     int rc = RTFileOpen(&hFile, pszPath, RTFILE_O_OPEN | RTFILE_O_READ);
     if (RT_SUCCESS(rc))
     {
-        RTFileGetSize(hFile, (uint64_t *)&cb);
+        RTFileGetSize(hFile, &cb);
         RTFileClose(hFile);
     }
     else
         CORELOGRELSYS((CORELOG_NAME "GetFileSize failed to open %s rc=%Rrc\n", pszPath, rc));
-    return cb;
+    return cb < ~(size_t)0 ? (size_t)cb : ~(size_t)0;
 }
 
@@ -351 +351 @@
     if (RT_SUCCESS(rc))
     {
-        RTFileGetSize(hFile, (uint64_t *)pcb);
+        RTFileGetSize(hFile, (uint64_t *)pcb); /** @todo size_t != uint64_t! */
         if (*pcb > 0)
         {
@@ -515 +515 @@
 
     size_t cbAuxFile = 0;
-    RTFileGetSize(hFile, (uint64_t *)&cbAuxFile);
+    RTFileGetSize(hFile, (uint64_t *)&cbAuxFile);  /** @todo size_t != uint64_t! */
     if (cbAuxFile >= sizeof(auxv_t))
     {
@@ -607 +607 @@
          */
         size_t cbMapFile = 0;
-        RTFileGetSize(hFile, (uint64_t *)&cbMapFile);
+        RTFileGetSize(hFile, (uint64_t *)&cbMapFile);  /** @todo size_t != uint64_t! */
         if (cbMapFile >= sizeof(prmap_t))
         {