Changeset 31934 in vbox for trunk

Timestamp:

Aug 24, 2010 4:11:16 PM (14 years ago)

Author:

vboxsync

Message:

VBoxService/PropCache: Fixed memory leak on destruction.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServicePropCache.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServicePropCache.cpp

@@ -369 +369 @@
         while (pNode)
         {
+            PVBOXSERVICEVEPROPCACHEENTRY pNext = RTListNodeIsLast(&pCache->NodeHead, &pNode->NodeSucc)
+                                                                  ? NULL :
+                                                                    RTListNodeGetNext(&pNode->NodeSucc,
+                                                                                      VBOXSERVICEVEPROPCACHEENTRY, NodeSucc);
+            RTListNodeRemove(&pNode->NodeSucc);
+
             /*
              * When destroying the cache and we have a temporary value, remove the
@@ -383 +389 @@
             pNode->fFlags = 0;
 
-            PVBOXSERVICEVEPROPCACHEENTRY pNext = RTListNodeGetNext(&pNode->NodeSucc, VBOXSERVICEVEPROPCACHEENTRY, NodeSucc);
-            RTListNodeRemove(&pNode->NodeSucc);
             RTMemFree(pNode);
 
-            if (pNext && RTListNodeIsLast(&pCache->NodeHead, &pNext->NodeSucc))
-                break;
             pNode = pNext;
         }