VirtualBox

Changeset 32032 in vbox for trunk/include/iprt


Ignore:
Timestamp:
Aug 27, 2010 9:51:03 AM (14 years ago)
Author:
vboxsync
Message:

iprt/string.h: use 80 colums, r=xxxx is for writing nasty review comments other peoples.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/include/iprt/string.h

    r31950 r32032  
    3535# include <linux/string.h>
    3636#elif defined(RT_OS_FREEBSD) && defined(_KERNEL)
    37 /**
    38  * XXX: Very ugly hack to get things build on recent FreeBSD
    39  * builds. They have memchr now and we need to include
    40  * param.h to get __FreeBSD_version and make
    41  * memchr available based on the version below
    42  * or we can't compile the kernel module on
    43  * older versions anymore.
    44  *
    45  * But including param.h here opens Pandora's box
    46  * because we clash with a few defines
    47  * namely PVM and PAGE_SIZE.
    48  * We can safely undefine PVM here but not PAGE_SIZE
    49  * because this results in build errors sooner or later.
    50  * Luckily this define is in a header included by param.h
    51  * (machine/param.h). We define the guards here
    52  * to prevent inclusion of it if PAGE_SIZE
    53  * was defined already.
    54  *
    55  * @todo r=aeichner: Search for an elegant solution
    56  *                   and cleanup this mess ASAP!
     37/** @todo
     38 * XXX: Very ugly hack to get things build on recent FreeBSD builds. They have
     39 * memchr now and we need to include param.h to get __FreeBSD_version and make
     40 * memchr available based on the version below or we can't compile the kernel
     41 * module on older versions anymore.
     42 *
     43 * But including param.h here opens Pandora's box because we clash with a few
     44 * defines namely PVM and PAGE_SIZE. We can safely undefine PVM here but not
     45 * PAGE_SIZE because this results in build errors sooner or later. Luckily this
     46 * define is in a header included by param.h (machine/param.h). We define the
     47 * guards here to prevent inclusion of it if PAGE_SIZE was defined already.
     48 *
     49 * @todo aeichner: Search for an elegant solution and cleanup this mess ASAP!
    5750 */
    5851# ifdef PAGE_SIZE
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette