Changeset 32376 in vbox for trunk/src/VBox/Runtime/r3/solaris

Timestamp:

Sep 10, 2010 9:22:06 AM (14 years ago)

Author:

vboxsync

Message:

Runtime/r3/coredumper: tighten signal handling code.

File:

• trunk/src/VBox/Runtime/r3/solaris/coredumper-solaris.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/r3/solaris/coredumper-solaris.cpp

@@ -2138 +2138 @@
             CORELOGRELSYS((CORELOG_NAME "TakeDump failed! rc=%Rrc\n", rc));
     }
-    else
+    else if (Sig == SIGSEGV || Sig == SIGBUS)
     {
         /*
@@ -2151 +2151 @@
          */
         if (ASMAtomicReadU64(&g_CoreDumpThread) != (uint64_t)RTThreadSelf())
+        {
+            CORELOGRELSYS((CORELOG_NAME "SignalHandler: Core dumper (thread %u) crashed Sig=%d. Triggering system dump\n",
+                           RTThreadSelf(), Sig));
             fCallSystemDump = true;
+        }
         else
         {
-            CORELOGRELSYS((CORELOG_NAME "SignalHandler: Core dump already in progress! Waiting before signalling Sig=%d.\n", Sig));
-            int64_t iTimeout = 10000;  /* timeout (ms) */
+            /*
+             * Some other thread in the process is triggering a crash, wait a while
+             * to let our core dumper finish, on timeout trigger system dump.
+             */
+            CORELOGRELSYS((CORELOG_NAME "SignalHandler: Core dump already in progress! Waiting a while for completion Sig=%d.\n", Sig));
+            int64_t iTimeout = 16000;  /* timeout (ms) */
             while (ASMAtomicReadBool(&g_fCoreDumpInProgress) == true)
             {
@@ -2166 +2174 @@
             {
                 fCallSystemDump = true;
-                CORELOGRELSYS((CORELOG_NAME "SignalHandler: Core dump seems to be stuck. Signalling new signal %d\n", Sig));
+                CORELOGRELSYS((CORELOG_NAME "SignalHandler: Core dumper seems to be stuck. Signalling new signal %d\n", Sig));
             }
         }