Changeset 32625 in vbox

Timestamp:

Sep 19, 2010 6:57:19 PM (14 years ago)

Author:

vboxsync

Message:

VMDK: Don't ignore block devices during a async flush request

File:

• trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp

@@ -7701 +7701 @@
             case VMDKETYPE_VMFS:
             case VMDKETYPE_FLAT:
-                /** @todo implement proper path absolute check. */
+                /*
+                 * Don't ignore block devices like in the sync case
+                 * (they have an absolute path).
+                 * We might have unwritten data in the writeback cache and
+                 * the async I/O manager will handle these requests properly
+                 * even if the block device doesn't support these requests.
+                 */
                 if (   pExtent->pFile != NULL
-                    && !(pImage->uOpenFlags & VD_OPEN_FLAGS_READONLY)
-                    && !(pExtent->pszBasename[0] == RTPATH_SLASH))
+                    && !(pImage->uOpenFlags & VD_OPEN_FLAGS_READONLY))
                     rc = vmdkFileFlushAsync(pImage, pExtent->pFile, pIoCtx);
                 break;