Changeset 32813 in vbox for trunk/src/VBox/Additions

Timestamp:

Sep 29, 2010 11:50:19 AM (14 years ago)

Author:

vboxsync

Message:

VBoxService: Some division through zero checks.

Location:

trunk/src/VBox/Additions/common/VBoxService

Files:

• VBoxServiceBalloon.cpp (modified) (1 diff)
• VBoxServiceStats.cpp (modified) (4 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceBalloon.cpp

@@ -305 +305 @@
 uint32_t VBoxServiceBalloonQueryPages(uint32_t cbPage)
 {
+    Assert(cbPage > 0);
     return g_cMemBalloonChunks * (VMMDEV_MEMORY_BALLOON_CHUNK_SIZE / cbPage);
 }

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceStats.cpp

@@ -266 +266 @@
         deltaKernel          -= deltaIdle;  /* idle time is added to kernel time */
         uint64_t ullTotalTime = deltaIdle + deltaKernel + deltaUser;
+        if (ullTotalTime == 0) /* Prevent division through zero. */
+            ullTotalTime = 1;
 
         req.guestStats.u32CpuLoad_Idle      = (uint32_t)(deltaIdle  * 100 / ullTotalTime);
@@ -412 +414 @@
                                             + u64DeltaUser
                                             + u64DeltaNice;
+                    if (u64DeltaAll == 0) /* Prevent division through zero. */
+                        u64DeltaAll = 1;
 
                     gCtx.au64LastCpuLoad_Idle[u32CpuId]   = u64Idle;
@@ -507 +511 @@
                     if (rc != -1)
                     {
+                        Assert(SysInfo.updates != 0);
                         u64PagedTotal = VMInfo.swap_avail / SysInfo.updates;
                     }
@@ -562 +567 @@
 
                 uint64_t u64DeltaAll    = u64DeltaIdle + u64DeltaSystem + u64DeltaUser;
+                if (u64DeltaAll == 0) /* Prevent division through zero. */
+                    u64DeltaAll = 1;
 
                 gCtx.au64LastCpuLoad_Idle[cCPUs]   = u64Idle;