Changeset 32820 in vbox for trunk/src/VBox/Devices/PC

Timestamp:

Sep 29, 2010 4:25:16 PM (14 years ago)

Author:

vboxsync

Message:

PCI, PDM: initial drop of MSI support

File:

• trunk/src/VBox/Devices/PC/DevAPIC.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/PC/DevAPIC.cpp

@@ -1449 +1449 @@
     index = (addr >> 4) & 0xff;
 
+    if (addr > 0xfff || (index == 0))
+    {
+        /* MSR area read, undefined result by spec */
+        Log(("APIC: MSR area read: %x\n", index));
+        return 0;
+    }
+
     switch(index) {
     case 0x02: /* id */
@@ -1523 +1530 @@
     return val;
 }
-
+/**
+ * See chapter 10.11 MESSAGE SIGNALLED INTERRUPTS of IA-32 Intel Architecture
+ * Software Developer’s Manual, Volume 3A: System Programming Guide, Part 1
+ * for details on MSI and LAPIC interaction.
+ */
 static int apicSendMsi(APICDeviceInfo* dev, RTGCPHYS addr, uint32_t val)
 {
@@ -1531 +1542 @@
     uint8_t  trigger_mode = (val >> VBOX_MSI_DATA_TRIGGER_SHIFT) & 0x1;
     uint8_t  delivery_mode = (val >> VBOX_MSI_DATA_DELIVERY_MODE_SHIFT) & 0x7;
-
+    /**
+     * This bit indicates whether the message should be directed to the
+     * processor with the lowest interrupt priority among
+     * processors that can receive the interrupt, ignored ATM.
+     */
+    uint8_t  redir_hint = (addr >> VBOX_MSI_ADDR_REDIRECTION_SHIFT) & 0x1;
     uint32_t deliver_bitmask = apic_get_delivery_bitmask(dev, dest, dest_mode);