Changeset 32852 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

Sep 30, 2010 3:49:35 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

66326

Message:

Guest Execution:

• Implemented "ignore orphaned childs" flag (--flags ignoreorphanedchilds); this flag will tell the host to not bitch about an executed process which still is alive when VBoxService (or the entire guest OS) shuts down.
• Fixed shutdown/notification hang when waiting for std output which never arrives.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -195 +195 @@
         else if (!strcmp(a->argv[i], "--flags"))
         {
-            if (   i + 1 >= a->argc
-                || RTStrToUInt32Full(a->argv[i + 1], 10, &uFlags) != VINF_SUCCESS)
-                usageOK = false;
-            else
-                ++i;
+            if (i + 1 >= a->argc)
+                usageOK = false;
+            else
+            {
+                /** @todo Needs a bit better processing as soon as we have more flags. */
+                if (!strcmp(a->argv[i + 1], "ignoreorphanedchilds"))
+                    uFlags |= ExecuteProcessFlag_IgnoreOrphanedProcesses;
+                else
+                    usageOK = false;
+                ++i;
+            }
         }
         else if (   !strcmp(a->argv[i], "--username")
@@ -409 +415 @@
                             }
                             cbOutputData = 0;
+                            fCompleted = true; /* rc contains a failure, so we'll go into aborted state down below. */
                         }
                         else
@@ -489 +496 @@
                     if (FAILED(iRc))
                     {
-                        ComPtr<IVirtualBoxErrorInfo> execError;
-                        rc = progress->COMGETTER(ErrorInfo)(execError.asOutParam());
-                        com::ErrorInfo info(execError, COM_IIDOF(IVirtualBoxErrorInfo));
-                        if (SUCCEEDED(rc) && info.isFullAvailable())
+                        com::ProgressErrorInfo info(progress);
+                        if (   info.isFullAvailable()
+                            || info.isBasicAvailable())
                         {
                             /* If we got a VBOX_E_IPRT error we handle the error in a more gentle way
@@ -505 +511 @@
                         }
                         else
-                            AssertMsgFailed(("Full error description is missing!\n"));
+                        {
+                            if (RT_FAILURE(rc))
+                                RTMsgError("Error while looking up error code, rc=%Rrc", rc);
+                            else
+                                com::GluePrintRCMessage(iRc);
+                        }
                     }
                     else if (fVerbose)