Changeset 32898 in vbox

Timestamp:

Oct 5, 2010 9:43:39 AM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

66381

Message:

Main: Drop the lock before triggering VMMDev/EMT activity during a CPU hotplug event

File:

• trunk/src/VBox/Main/ConsoleImpl.cpp (modified) (7 diffs)

trunk/src/VBox/Main/ConsoleImpl.cpp

@@ -1841 +1841 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    /** @todo r=klaus holding the lock while triggering VMMDev/EMT activity is
-     * asking for deadlocks. Code MUST drop any lock before touching VMMDev. */
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
@@ -1868 +1866 @@
                         tr("CPU %d is not attached"), aCpu);
 
+    /* Leave the lock before any EMT/VMMDev call. */
+    alock.leave();
+
     /* Check if the CPU is unlocked */
     PPDMIBASE pBase;
@@ -1913 +1914 @@
         /*
          * Call worker in EMT, that's faster and safer than doing everything
-         * using VMR3ReqCall. Note that we separate VMR3ReqCall from VMR3ReqWait
-         * here to make requests from under the lock in order to serialize them.
+         * using VMR3ReqCall.
          */
         PVMREQ pReq;
@@ -1921 +1921 @@
                           this, aCpu);
 
-        /* leave the lock before a VMR3* call (EMT will call us back)! */
-        alock.leave();
-
         if (vrc == VERR_TIMEOUT || RT_SUCCESS(vrc))
         {
@@ -1999 +1996 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    /** @todo r=klaus holding the lock while triggering VMMDev/EMT activity is
-     * asking for deadlocks. Code MUST drop any lock before touching VMMDev. */
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
@@ -3880 +3875 @@
     AssertComRCReturnRC(autoCaller.rc());
 
-    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
-
     HRESULT rc = S_OK;
 
@@ -3887 +3880 @@
     if (mpVM)
     {
-        /* protect mpVM */
-        AutoVMCaller autoVMCaller(this);
-        if (FAILED(autoVMCaller.rc())) return autoVMCaller.rc();
-
         if (aRemove)
             rc = doCPURemove(aCPU);