Changeset 32910 in vbox

Timestamp:

Oct 5, 2010 12:33:56 PM (14 years ago)

Author:

vboxsync

Message:

VMM: hyper heap size selection

Location:

trunk/src/VBox

Files:

• Main/ConsoleImpl2.cpp (modified) (2 diffs)
• VMM/MMHyper.cpp (modified) (3 diffs)

trunk/src/VBox/Main/ConsoleImpl2.cpp

@@ -311 +311 @@
 }
 
-static uint32_t computeHyperHeapSize(ChipsetType_T chipsetType, uint32_t cCpus, bool fHwVirtExtForced)
-{
-    uint32_t singleCpuBaseSize;
-
-    if (cCpus > 1)
-        return _2M + cCpus * _64K;
-
-    if (chipsetType == ChipsetType_PIIX3)
-    {
-        /* Size must be kept like this for saved state compatibility */
-        return fHwVirtExtForced ? 640*_1K : 1280*_1K;
-    }
-
-
-    return 1280*_1K;
-}
-
 class ConfigError : public iprt::Error
 {
@@ -700 +683 @@
          */
         PCFGMNODE pMM;
-        uint32_t cbHyperHeap = computeHyperHeapSize(chipsetType, cCpus, fHwVirtExtForced);
         InsertConfigNode(pRoot, "MM", &pMM);
-        InsertConfigInteger(pMM, "cbHyperHeap", cbHyperHeap);
+        InsertConfigInteger(pMM, "CanUseLargerHeap", chipsetType == ChipsetType_ICH9);
 
         /*

trunk/src/VBox/VMM/MMHyper.cpp

@@ -45 +45 @@
 
 
+DECLINLINE(uint32_t) computeHyperHeapSize(bool fCanUseLargerHeap, uint32_t cCpus, bool fHwVirtExtForced)
+{
+    if (cCpus > 1)
+        return _2M + cCpus * _64K;
+
+    if (fCanUseLargerHeap)
+        return 1280*_1K;
+    else
+        /* Size must be kept like this for saved state compatibility */
+        return fHwVirtExtForced ? 640*_1K : 1280*_1K;
+}
 
 
@@ -73 +84 @@
      *        precious kernel space on heap for the PATM.
      */
-    uint32_t cbHyperHeap;
-    int rc = CFGMR3QueryU32(CFGMR3GetChild(CFGMR3GetRoot(pVM), "MM"), "cbHyperHeap", &cbHyperHeap);
+    PCFGMNODE pMM = CFGMR3GetChild(CFGMR3GetRoot(pVM), "MM");
+    bool fCanUseLargerHeap = false;
+    int rc = CFGMR3QueryBoolDef(pMM, "CanUseLargerHeap", &fCanUseLargerHeap, false);
+    uint32_t cbHyperHeap = computeHyperHeapSize(fCanUseLargerHeap, pVM->cCpus, VMMIsHwVirtExtForced(pVM));
+    rc = CFGMR3QueryU32Def(pMM, "cbHyperHeap", &cbHyperHeap, cbHyperHeap);
     AssertLogRelRCReturn(rc, rc);
+
     cbHyperHeap = RT_ALIGN_32(cbHyperHeap, PAGE_SIZE);
     LogRel(("MM: cbHyperHeap=%#x (%u)\n", cbHyperHeap, cbHyperHeap));
@@ -1375 +1390 @@
     }
 }
-