Changeset 32964 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Oct 7, 2010 8:29:39 AM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

66469

Message:

DevPCNet: work around a WinXP driver bug which clears CSR0.TINT after it set CSR0.TDMD

File:

• trunk/src/VBox/Devices/Network/DevPCNet.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -197 +197 @@
     uint16_t                            aBCR[BCR_MAX_RAP];
     uint16_t                            aMII[MII_MAX_REG];
+    /** Holds the bits which were really seen by the guest. Relevant are bits
+     * 8..14 (IDON, TINT, RINT, MERR, MISS, CERR, BABL). We don't allow the
+     * guest to clear any of these bits (by writing a ONE) before a bit was
+     * seen by the guest. */
     uint16_t                            u16CSR0LastSeenByGuest;
     uint16_t                            Alignment2[HC_ARCH_BITS == 32 ? 2 : 2];
@@ -2539 +2543 @@
                     tmd.tmd2.buff = tmd.tmd2.uflo = tmd.tmd1.err = 1;
                     pThis->aCSR[0] |= 0x0200;        /* set TINT */
+                    /* Don't allow the guest to clear TINT before reading it */
+                    pThis->u16CSR0LastSeenByGuest &= ~0x0200;
                     if (!CSR_DXSUFLO(pThis))         /* stop on xmit underflow */
                         pThis->aCSR[0] &= ~0x0010;   /* clear TXON */
@@ -2626 +2632 @@
     {
         STAM_COUNTER_INC(&pThis->aStatXmitFlush[RT_MIN(cFlushIrq, RT_ELEMENTS(pThis->aStatXmitFlush)) - 1]);
+        /* The WinXP PCnet driver has apparently a bug: It sets CSR0.TDMD _before_
+         * it clears CSR0.TINT. This can lead to a race where the driver clears
+         * CSR0.TINT right after it was set by the device. The driver waits until
+         * CSR0.TINT is set again but this will never happen. So prevent clearing
+         * this bit as long as the driver didn't read it. */
         pThis->aCSR[0] |= 0x0200;    /* set TINT */
+        /* Don't allow the guest to clear TINT before reading it */
+        pThis->u16CSR0LastSeenByGuest &= ~0x0200;
         pcnetUpdateIrq(pThis);
     }