Changeset 32982 in vbox for trunk/src/VBox/Devices/PC

Timestamp:

Oct 7, 2010 3:12:02 PM (14 years ago)

Author:

vboxsync

Message:

DevAPIC: Addressed the cause of the div by zero problem in apicDoFrequencyHinting - it was the cause of the DSL hang on systems with an VMX preemption timer.

File:

• trunk/src/VBox/Devices/PC/DevAPIC.cpp (modified) (8 diffs)

trunk/src/VBox/Devices/PC/DevAPIC.cpp

@@ -1253 +1253 @@
         pThis->uHintedCountShift    = pThis->count_shift;
 
-        uint64_t cTickPerPeriod = (uint64_t)pThis->initial_count << pThis->count_shift;
-        uint32_t uHz = cTickPerPeriod > 0
-                     ? TMTimerGetFreq(pThis->CTX_SUFF(pTimer)) / cTickPerPeriod
-                     : 100 /*whatever*/;
+        uint32_t uHz;
+        if (pThis->initial_count > 0)
+        {
+            Assert((unsigned)pThis->count_shift < 30);
+            uint64_t cTickPerPeriod = ((uint64_t)pThis->initial_count + 1) << pThis->count_shift;
+            uHz = TMTimerGetFreq(pThis->CTX_SUFF(pTimer)) / cTickPerPeriod;
+        }
+        else
+            uHz = 0;
         TMTimerSetFrequencyHint(pThis->CTX_SUFF(pTimer), uHz);
         Log(("apic: %u Hz\n", uHz));
@@ -1278 +1283 @@
      * a zero length one-shot timer.
      */
-    /** @todo check the correct behavior of setting a 0 initial_count for a one-shot
-     *        timer. This is just copying the behavior of the original code. */
     if (    !(pThis->lvt[APIC_LVT_TIMER] & APIC_LVT_MASKED)
-        &&  (   (pThis->lvt[APIC_LVT_TIMER] & APIC_LVT_TIMER_PERIODIC)
-             || u32NewInitialCount != 0))
+        &&  u32NewInitialCount > 0)
     {
         /*
@@ -1296 +1298 @@
         apicDoFrequencyHinting(pThis);
         STAM_COUNTER_INC(&pThis->StatTimerSetInitialCountArm);
+        Log(("apicTimerSetInitialCount: cTicksNext=%'llu (%#llx) ic=%#x sh=%#x nxt=%#llx\n", cTicksNext, cTicksNext, u32NewInitialCount, pThis->count_shift, pThis->next_time));
     }
     else
@@ -1308 +1311 @@
         }
         pThis->initial_count_load_time = TMTimerGet(pThis->CTX_SUFF(pTimer));
+        Log(("apicTimerSetInitialCount: ic=%#x sh=%#x iclt=%#llx\n", u32NewInitialCount, pThis->count_shift, pThis->initial_count_load_time));
     }
 }
@@ -1365 +1369 @@
             STAM_COUNTER_INC(&pThis->StatTimerSetLvtArmed);
         /*
-         * If unmasked and not armed, we have to rearm the timer so it will
-         * fire at the end of the current period.
-         * This is code is currently RACING the virtual sync clock!
+         * If unmasked, not armed and with a valid initial count value (according
+         * to our interpretation of the spec), we will have to rearm the timer so
+         * it will fire at the end of the current period.
+         *
+         * N.B. This is code is currently RACING the virtual sync clock!
          */
-        else if (fOld & APIC_LVT_MASKED)
+        else if (   (fOld & APIC_LVT_MASKED)
+                 && pThis->initial_count > 0)
         {
             STAM_COUNTER_INC(&pThis->StatTimerSetLvtArm);
@@ -1395 +1402 @@
                     pThis->fTimerArmed = true;
                     apicDoFrequencyHinting(pThis);
+                    Log(("apicTimerSetLvt: ic=%#x sh=%#x nxt=%#llx\n", pThis->initial_count, pThis->count_shift, pThis->next_time));
                     break;
                 }
@@ -1424 +1432 @@
         apic_set_irq(dev, pThis, pThis->lvt[APIC_LVT_TIMER] & 0xff, APIC_TRIGGER_EDGE);
 
-        if (pThis->lvt[APIC_LVT_TIMER] & APIC_LVT_TIMER_PERIODIC) {
+        if (   (pThis->lvt[APIC_LVT_TIMER] & APIC_LVT_TIMER_PERIODIC)
+            && pThis->initial_count > 0) {
             /* new interval. */
             pThis->next_time += (((uint64_t)pThis->initial_count + 1) << pThis->count_shift);
@@ -1430 +1439 @@
             pThis->fTimerArmed = true;
             apicDoFrequencyHinting(pThis);
+            Log2(("apicTimerCallback: ic=%#x sh=%#x nxt=%#llx\n", pThis->initial_count, pThis->count_shift, pThis->next_time));
         } else {
-            /* single shot. */
+            /* single shot or disabled. */
             pThis->fTimerArmed = false;
             pThis->uHintedCountShift = pThis->uHintedInitialCount = 0;