Changeset 33031 in vbox

Timestamp:

Oct 11, 2010 8:42:53 AM (14 years ago)

Author:

vboxsync

Message:

Devices: global define for using MSI support in devices

Location:

trunk

Files:

• Config.kmk (modified) (1 diff)
• src/VBox/Devices/Audio/DevIchIntelHDA.cpp (modified) (5 diffs)
• src/VBox/Devices/Storage/DevAHCI.cpp (modified) (3 diffs)
• src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp (modified) (4 diffs)

trunk/Config.kmk

@@ -397 +397 @@
 # Enable this setting to force a fallback to default DMI data on configuration errors
 VBOX_BIOS_DMI_FALLBACK =
+# Enable MSI support in devices
+# VBOX_WITH_MSI_DEVICES = 1
 # Enable host network interface API.
 if1of ($(KBUILD_TARGET), darwin freebsd linux solaris win)

trunk/src/VBox/Devices/Audio/DevIchIntelHDA.cpp

@@ -1631 +1631 @@
 
 //#define HDA_AS_PCI_EXPRESS
-//#define HDA_WITH_MSI
 
 /**
@@ -1669 +1668 @@
     PCIDevSetDeviceId           (&pThis->dev, 0x30f7); /* HP Pavilion dv4t-1300 */
 #else
-#if 1 
+#if 1
     PCIDevSetVendorId           (&pThis->dev, 0x8086); /* 00 ro - intel. */
     PCIDevSetDeviceId           (&pThis->dev, 0x2668); /* 02 ro - 82801 / 82801aa(?). */
@@ -1695 +1694 @@
 #if defined(HDA_AS_PCI_EXPRESS)
     PCIDevSetCapabilityList     (&pThis->dev, 0x80);
-#elif defined(HDA_WITH_MSI)
+#elif defined(VBOX_WITH_MSI_DEVICES)
     PCIDevSetCapabilityList     (&pThis->dev, 0x60);
 #else
@@ -1767 +1766 @@
         return rc;
 
-#ifdef HDA_WITH_MSI
+#ifdef VBOX_WITH_MSI_DEVICES
     PDMMSIREG aMsiReg;
     aMsiReg.cVectors = 1;
@@ -1774 +1773 @@
     aMsiReg.iMsiFlags = 0;
     rc = PDMDevHlpPCIRegisterMsi(pDevIns, &aMsiReg);
-    AssertRC(rc);
     if (RT_FAILURE (rc))
-        return rc;
+    {
+        LogRel(("Chipset cannot do MSI: %Rrc\n", rc));
+        PCIDevSetCapabilityList     (&pThis->dev, 0x50);
+    }
 #endif
 

trunk/src/VBox/Devices/Storage/DevAHCI.cpp

@@ -70 +70 @@
  * This was before the config was added and ahciIOTasks was dropped. */
 #define AHCI_SAVED_STATE_VERSION_VBOX_30        2
-
-/* If AHCI shall emulate MSI support */
-#define AHCI_WITH_MSI
 
 /**
@@ -7853 +7850 @@
     PCIDevSetDeviceId    (&pThis->dev, 0x2829); /* ICH-8M */
     PCIDevSetCommand     (&pThis->dev, 0x0000);
-#ifdef AHCI_WITH_MSI
+#ifdef VBOX_WITH_MSI_DEVICES
     PCIDevSetStatus      (&pThis->dev, VBOX_PCI_STATUS_CAP_LIST);
     PCIDevSetCapabilityList(&pThis->dev, 0x80);
@@ -7885 +7882 @@
         return rc;
 
-#ifdef AHCI_WITH_MSI
+#ifdef VBOX_WITH_MSI_DEVICES
     PDMMSIREG aMsiReg;
     aMsiReg.cVectors = 1;

trunk/src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp

@@ -48 +48 @@
 /** Maximum number of entries in the release log. */
 #define MAX_REL_LOG_ERRORS 1024
-
-/* If LSI shall emulate MSI support */
-#define LSILOGIC_WITH_MSI
 
 /**
@@ -5017 +5014 @@
     PCIDevSetInterruptPin(&pThis->PciDev,   0x01); /* Interrupt pin A */
 
-#ifdef LSILOGIC_WITH_MSI
+#ifdef VBOX_WITH_MSI_DEVICES
     PCIDevSetStatus(&pThis->PciDev,   VBOX_PCI_STATUS_CAP_LIST);
     PCIDevSetCapabilityList(&pThis->PciDev, 0x80);
@@ -5035 +5032 @@
         return rc;
 
-#ifdef LSILOGIC_WITH_MSI
+#ifdef VBOX_WITH_MSI_DEVICES
     PDMMSIREG aMsiReg;
     aMsiReg.cVectors = 1;
@@ -5046 +5043 @@
         LogRel(("Chipset cannot do MSI: %Rrc\n", rc));
         /* That's OK, we can work without MSI */
+        PCIDevSetCapabilityList(&pThis->PciDev, 0x0);
     }
 #endif