Changeset 33044 in vbox for trunk/src/libs/xpcom18a4/ipc/ipcd

Timestamp:

Oct 11, 2010 4:30:54 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

66568

Message:

iprt/process: eliminate RTPROC_FLAGS_DAEMONIZE_DEPRECATED, rework starting a detached process on posix platforms and eliminate one useless fork(), avoid running

atexit functions in the temporary process

XPCOM: more detached process rework, block anything not going through IPRT, clos
e a few file descriptor inheritance leaks, and clean up the file descriptor pass
ing to VBoxXPCOMIPCD

Location:

trunk/src/libs/xpcom18a4/ipc/ipcd

Files:

• client/src/ipcdclient.cpp (modified) (2 diffs)
• daemon/src/ipcdUnix.cpp (modified) (4 diffs)

trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcdclient.cpp

@@ -1216 +1216 @@
   PRProcessAttr *attr = nsnull;
   nsresult rv = NS_ERROR_FAILURE;
+  PRFileDesc *devNull;
   char *const argv[] = { (char *const) path, nsnull };
   char c;
@@ -1233 +1234 @@
 
   if (PR_ProcessAttrSetInheritableFD(attr, writable, IPC_STARTUP_PIPE_NAME) != PR_SUCCESS)
+  goto end;
+
+  devNull = PR_Open("/dev/null", PR_RDWR, 0);
+  if (!devNull)
     goto end;
+
+  PR_ProcessAttrSetStdioRedirect(attr, PR_StandardInput, devNull);
+  PR_ProcessAttrSetStdioRedirect(attr, PR_StandardOutput, devNull);
+  PR_ProcessAttrSetStdioRedirect(attr, PR_StandardError, devNull);
 
   if (PR_CreateProcessDetached(path, argv, nsnull, attr) != PR_SUCCESS)
     goto end;
 
+  // Close /dev/null
+  PR_Close(devNull);
   // close the child end of the pipe in order to get notification on unexpected
   // child termination instead of being infinitely blocked in PR_Read().

trunk/src/libs/xpcom18a4/ipc/ipcd/daemon/src/ipcdUnix.cpp

@@ -50 +50 @@
 #endif
 
+#ifdef VBOX
+# include <iprt/initterm.h>
+#endif
+
 #include "prio.h"
 #include "prerror.h"
@@ -467 +471 @@
     PRFileDesc *listenFD = NULL;
     PRNetAddr addr;
+
+#ifdef VBOX
+    /* Set up the runtime without loading the support driver. */
+    RTR3Init();
+#endif
 
     //
@@ -537 +546 @@
         }
         else {
+#ifndef VBOX
             // redirect all standard file descriptors to /dev/null for
             // proper daemonizing
@@ -545 +555 @@
             PR_Close(PR_STDERR);
             PR_Open("/dev/null", O_WRONLY, 0);
+#endif
 
             IPC_NotifyParent();