Changeset 33292 in vbox

Timestamp:

Oct 21, 2010 10:33:12 AM (14 years ago)

Author:

vboxsync

Message:

VBoxService/Guest Execution: Destroy local stdin pipe buffer when process is dead.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlExec.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlExec.cpp

@@ -47 +47 @@
 extern RTLISTNODE g_GuestControlExecThreads;
 
+void VBoxServiceControlExecDeletePipeBuffer(PVBOXSERVICECTRLEXECPIPEBUF pBuf);
+
 
 /**
@@ -544 +546 @@
     if (RT_SUCCESS(rc))
     {
-        /** WRONG CONTEXT ID!!!! */
-#if 0
-        rc = VbglR3GuestCtrlExecReportStatusIn(pThread->uClientID, pThread->uContextID, pData->uPID,
-                                               INPUT_STS_TERMINATED, 0 /* Flags */, 0);
-
-        rc = VbglR3GuestCtrlExecSendOut(pThread->uClientID, pThread->uContextID, pData->uPID,
-                                        0 /* Handle ID */, 0 /* Flags */, NULL, 0);
-#endif
+        /* Since the process is not alive anymore, destroy its local
+         * stdin pipe buffer - it's not used anymore and can eat up quite
+         * a bit of memory. */
+        VBoxServiceControlExecDeletePipeBuffer(&pData->stdIn);
 
         uint32_t uStatus = PROC_STS_UNDEFINED;
@@ -712 +710 @@
 {
     AssertPtr(pBuf);
-    RTMemFree(pBuf->pbData);
-    pBuf->pbData = NULL;
-    pBuf->cbAllocated = 0;
-    pBuf->cbSize = 0;
-    pBuf->cbOffset = 0;
-    pBuf->fAlive = false;
+    if (pBuf->pbData)
+    {
+        RTMemFree(pBuf->pbData);
+        pBuf->pbData = NULL;
+        pBuf->cbAllocated = 0;
+        pBuf->cbSize = 0;
+        pBuf->cbOffset = 0;
+        pBuf->fAlive = false;
+    }
 
     RTPipeClose(pBuf->hNotificationPipeR);