Changeset 33355 in vbox

Timestamp:

Oct 22, 2010 1:47:08 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

66939

Message:

Storage/VBoxHDD: make diff/base image creation fail with an appropriate error if the backend cannot handle this

File:

• trunk/src/VBox/Devices/Storage/VBoxHDD.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/VBoxHDD.cpp

@@ -4533 +4533 @@
             break;
         }
+        if (!(pImage->Backend->uBackendCaps & (  VD_CAP_CREATE_FIXED
+                                               | VD_CAP_CREATE_DYNAMIC)))
+        {
+            rc = vdError(pDisk, VERR_INVALID_PARAMETER, RT_SRC_POS,
+                         N_("VD: backend '%s' cannot create base images"), pszBackend);
+            break;
+        }
 
         /* Create UUID if the caller didn't specify one. */
@@ -4766 +4773 @@
             rc = vdError(pDisk, VERR_INVALID_PARAMETER, RT_SRC_POS,
                          N_("VD: unknown backend name '%s'"), pszBackend);
+            break;
+        }
+        if (   !(pImage->Backend->uBackendCaps & VD_CAP_DIFF)
+            || !(pImage->Backend->uBackendCaps & (  VD_CAP_CREATE_FIXED
+                                                  | VD_CAP_CREATE_DYNAMIC)))
+        {
+            rc = vdError(pDisk, VERR_INVALID_PARAMETER, RT_SRC_POS,
+                         N_("VD: backend '%s' cannot create diff images"), pszBackend);
             break;
         }