Changeset 33363 in vbox for trunk/src

Timestamp:

Oct 22, 2010 3:14:39 PM (14 years ago)

Author:

vboxsync

Message:

VBoxManage: document the disabled code

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageAppliance.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageAppliance.cpp

@@ -105 +105 @@
     { "--type",                 'T', RTGETOPT_REQ_UINT32 },     // deprecated
     { "-type",                  'T', RTGETOPT_REQ_UINT32 },     // deprecated
-//    { "--controller",           'C', RTGETOPT_REQ_STRING },
+#if 0 /* Changing the controller is fully valid, but the current design on how
+         the params are evaluated here doesn't allow two parameter for one
+         unit. The target disk path is more importend. I leave it for future
+         improvments. */
+    { "--controller",           'C', RTGETOPT_REQ_STRING },
+#endif
     { "--disk",                 'D', RTGETOPT_REQ_STRING },
 };
@@ -625 +630 @@
                                             aExtraConfigValues[a]);
                                 }
-//                                Utf8StrFmt strTypeArg("controller%u", a);
-//                                if (findArgValue(strOverride, pmapArgs, strTypeArg))
-//                                {
+#if 0 /* Changing the controller is fully valid, but the current design on how
+         the params are evaluated here doesn't allow two parameter for one
+         unit. The target disk path is more importend. I leave it for future
+         improvments. */
+                                Utf8StrFmt strTypeArg("controller%u", a);
+                                if (findArgValue(strOverride, pmapArgs, strTypeArg))
+                                {
                                     // strOverride now has the controller index as a number, but we
                                     // need a "controller=X" format string
-//                                    strOverride = Utf8StrFmt("controller=%s", strOverride.c_str());
-//                                    Bstr bstrExtraConfigValue = strOverride;
-//                                    bstrExtraConfigValue.detachTo(&aExtraConfigValues[a]);
-//                                    RTPrintf("%2u: Hard disk image: source image=%ls, target path=%ls, %ls\n",
-//                                            a,
-//                                            aOvfValues[a],
-//                                            aVboxValues[a],
-//                                            aExtraConfigValues[a]);
-//                                }
+                                    strOverride = Utf8StrFmt("controller=%s", strOverride.c_str());
+                                    Bstr bstrExtraConfigValue = strOverride;
+                                    bstrExtraConfigValue.detachTo(&aExtraConfigValues[a]);
+                                    RTPrintf("%2u: Hard disk image: source image=%ls, target path=%ls, %ls\n",
+                                            a,
+                                            aOvfValues[a],
+                                            aVboxValues[a],
+                                            aExtraConfigValues[a]);
+                                }
+#endif
                                 else
                                     RTPrintf("%2u: Hard disk image: source image=%ls, target path=%ls, %ls"