Changeset 33464 in vbox for trunk/src/VBox/Runtime/common/misc

Timestamp:

Oct 26, 2010 12:27:50 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

67055

Message:

*: Fixes for incorrect RTStrAPrintf usage (it does NOT return an IPRT status code) and the odd bugs nearby.

File:

• trunk/src/VBox/Runtime/common/misc/tar.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/common/misc/tar.cpp

@@ -1298 +1298 @@
 
         uint64_t cbOverallWritten = 0;
-        for(size_t i=0; i < cFiles; ++i)
+        for (size_t i = 0; i < cFiles; ++i)
         {
             RTTARFILE hFile;
@@ -1304 +1304 @@
             if (RT_FAILURE(rc))
                 break;
-            char *pszTargetFile;
-            rc = RTStrAPrintf(&pszTargetFile, "%s/%s", pszOutputDir, papszFiles[i]);
-            if (RT_FAILURE(rc))
-                break;
+            char *pszTargetFile = RTPathJoinA(pszOutputDir, papszFiles[i]);
+            if (!pszTargetFile)
+            {
+                rc = VERR_NO_STR_MEMORY;
+                break;
+            }
             rc = rtTarExtractFileToFile(hFile, pszTargetFile, cbOverallSize, cbOverallWritten, pfnProgressCallback, pvUser);
             RTStrFree(pszTargetFile);