Changeset 33489 in vbox for trunk

Timestamp:

Oct 27, 2010 10:31:41 AM (14 years ago)

Author:

vboxsync

Message:

VBoxManage: simplification, loop was nonsense

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageDHCPServer.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageDHCPServer.cpp

@@ -279 +279 @@
 int handleDHCPServer(HandlerArg *a)
 {
-    int result = 0;
     if (a->argc < 1)
         return errorSyntax(USAGE_DHCPSERVER, "Not enough parameters");
 
-    for (int i = 0; i < a->argc; i++)
-    {
-        if (strcmp(a->argv[i], "modify") == 0)
-        {
-            int cProcessed;
-            result = handleOp(a, OP_MODIFY, i+1, &cProcessed);
-            break;
-        }
-        else if (strcmp(a->argv[i], "add") == 0)
-        {
-            int cProcessed;
-            result = handleOp(a, OP_ADD, i+1, &cProcessed);
-            break;
-        }
-        else if (strcmp(a->argv[i], "remove") == 0)
-        {
-            int cProcessed;
-            result = handleOp(a, OP_REMOVE, i+1, &cProcessed);
-            break;
-        }
-        else
-        {
-            result = errorSyntax(USAGE_DHCPSERVER, "Invalid parameter '%s'", Utf8Str(a->argv[i]).c_str());
-            break;
-        }
-    }
+    int result;
+    int cProcessed;
+    if (strcmp(a->argv[0], "modify") == 0)
+        result = handleOp(a, OP_MODIFY, 1, &cProcessed);
+    else if (strcmp(a->argv[0], "add") == 0)
+        result = handleOp(a, OP_ADD, 1, &cProcessed);
+    else if (strcmp(a->argv[0], "remove") == 0)
+        result = handleOp(a, OP_REMOVE, 1, &cProcessed);
+    else
+        result = errorSyntax(USAGE_DHCPSERVER, "Invalid parameter '%s'", Utf8Str(a->argv[0]).c_str());
 
     return result;