Changeset 33540 in vbox for trunk/src/VBox/Debugger
- Timestamp:
- Oct 28, 2010 9:27:05 AM (14 years ago)
- svn:sync-xref-src-repo-rev:
- 67140
- Location:
- trunk/src/VBox/Debugger
- Files:
-
- 12 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/src/VBox/Debugger/DBGCEmulateCodeView.cpp
r32036 r33540 1058 1058 unsigned cTries = 32; 1059 1059 int iRangeLeft = (int)pDbgc->DisasmPos.u64Range; 1060 if (iRangeLeft == 0) /* klu gde for 'r'. */1060 if (iRangeLeft == 0) /* kludge for 'r'. */ 1061 1061 iRangeLeft = -1; 1062 1062 for (;;) … … 1205 1205 DBGFLINE LinePrev = { 0, 0, "" }; 1206 1206 int iRangeLeft = (int)pDbgc->SourcePos.u64Range; 1207 if (iRangeLeft == 0) /* klu gde for 'r'. */1207 if (iRangeLeft == 0) /* kludge for 'r'. */ 1208 1208 iRangeLeft = -1; 1209 1209 for (;;) … … 1744 1744 else 1745 1745 { 1746 RTGCINTPTR offDisp = pFrame->AddrPC.FlatPtr - pFrame->pSymPC->Value; /** @todo this isn't 100% correct for seg emnted stuff. */1746 RTGCINTPTR offDisp = pFrame->AddrPC.FlatPtr - pFrame->pSymPC->Value; /** @todo this isn't 100% correct for segmented stuff. */ 1747 1747 if (offDisp > 0) 1748 1748 rc = pCmdHlp->pfnPrintf(pCmdHlp, NULL, " %s+%llx", pFrame->pSymPC->szName, (int64_t)offDisp); … … 2107 2107 { 2108 2108 /* 2109 * Retri ve the selector value from the argument.2109 * Retrieve the selector value from the argument. 2110 2110 * The parser may confuse pointers and numbers if more than one 2111 2111 * argument is given, that that into account. 2112 2112 */ 2113 /* check that what 've got makes sense as we don't trust the parser yet. */2113 /* check that what we got makes sense as we don't trust the parser yet. */ 2114 2114 if ( paArgs[i].enmType != DBGCVAR_TYPE_NUMBER 2115 2115 && !DBGCVAR_ISPOINTER(paArgs[i].enmType)) … … 2241 2241 for (unsigned i = 0; i < cArgs; i++) 2242 2242 { 2243 /* check that what 've got makes sense as we don't trust the parser yet. */2243 /* check that what we got makes sense as we don't trust the parser yet. */ 2244 2244 if (paArgs[i].enmType != DBGCVAR_TYPE_NUMBER) 2245 2245 return pCmdHlp->pfnPrintf(pCmdHlp, NULL, "error: arg #%u isn't of number type but %d.\n", i, paArgs[i].enmType); … … 2515 2515 * @param pfPSE Where to store the page size extension indicator. 2516 2516 * @param pfPGE Where to store the page global enabled indicator. 2517 * @param pfNXE Where to store the no-execution enabled in idicator.2517 * @param pfNXE Where to store the no-execution enabled indicator. 2518 2518 */ 2519 2519 static RTGCPHYS dbgcGetGuestPageMode(PDBGC pDbgc, bool *pfPAE, bool *pfLME, bool *pfPSE, bool *pfPGE, bool *pfNXE) … … 2546 2546 * @param pfPSE Where to store the page size extension indicator. 2547 2547 * @param pfPGE Where to store the page global enabled indicator. 2548 * @param pfNXE Where to store the no-execution enabled in idicator.2548 * @param pfNXE Where to store the no-execution enabled indicator. 2549 2549 */ 2550 2550 static RTHCPHYS dbgcGetShadowPageMode(PDBGC pDbgc, bool *pfPAE, bool *pfLME, bool *pfPSE, bool *pfPGE, bool *pfNXE) … … 2621 2621 2622 2622 /* 2623 * Setup default ar ugment if none was specified.2623 * Setup default argument if none was specified. 2624 2624 * Fix address / index confusion. 2625 2625 */ … … 2685 2685 { 2686 2686 /* 2687 * Determin the range.2687 * Determine the range. 2688 2688 */ 2689 2689 switch (paArgs[0].enmRangeType) … … 3059 3059 { 3060 3060 /* 3061 * Determin the range.3061 * Determine the range. 3062 3062 */ 3063 3063 switch (paArgs[0].enmRangeType) … … 3350 3350 3351 3351 /* 3352 * Determin the TSS type if none is currently given.3352 * Determine the TSS type if none is currently given. 3353 3353 */ 3354 3354 if (enmTssType == kTssToBeDetermined) … … 4024 4024 4025 4025 /* 4026 * Repeat eprevious search?4026 * Repeat previous search? 4027 4027 */ 4028 4028 if (cArgs == 0) -
trunk/src/VBox/Debugger/DBGCInternal.h
r31987 r33540 93 93 * Named variable. 94 94 * 95 * Always allocated from heap in one si gnle block.95 * Always allocated from heap in one single block. 96 96 */ 97 97 typedef struct DBGCNAMEDVAR … … 172 172 uint8_t cPagingHierarchyDumps; 173 173 174 /** Current dis sassembler position. */174 /** Current disassembler position. */ 175 175 DBGCVAR DisasmPos; 176 176 /** Current source position. (flat GC) */ -
trunk/src/VBox/Debugger/DBGCOps.cpp
r31928 r33540 141 141 142 142 /** 143 * Switch the factors/what ver so we preserve pointers.143 * Switch the factors/whatever so we preserve pointers. 144 144 * Far pointers are considered more important that physical and flat pointers. 145 145 * … … 202 202 203 203 /** 204 * Conver s an argument to a number value.204 * Converts an argument to a number value. 205 205 * 206 206 * @returns VBox status code. … … 299 299 300 300 /** 301 * Plus s(unary).301 * Plus (unary). 302 302 * 303 303 * @returns VINF_SUCCESS on success. … … 1103 1103 1104 1104 /** 1105 * Subtra tion operator (binary).1105 * Subtraction operator (binary). 1106 1106 * 1107 1107 * @returns VINF_SUCCESS on success. … … 1632 1632 * @param pszExpr Pointer to the expression string which might start with an operator. 1633 1633 * @param fPreferBinary Whether to favour binary or unary operators. 1634 * Caller must assert that it's the d isired type! Both types will still1634 * Caller must assert that it's the desired type! Both types will still 1635 1635 * be returned, this is only for resolving duplicates. 1636 1636 * @param chPrev The previous char. Some operators requires a blank in front of it. … … 1660 1660 1661 1661 /* 1662 * Prefer ed type?1662 * Preferred type? 1663 1663 */ 1664 1664 if (g_aOps[iOp].fBinary == fPreferBinary) -
trunk/src/VBox/Debugger/DBGCTcp.cpp
r31530 r33540 269 269 270 270 /** 271 * Terminates any running TCP base debugger consol se service.271 * Terminates any running TCP base debugger console service. 272 272 * 273 273 * @returns VBox status. -
trunk/src/VBox/Debugger/DBGConsole.cpp
r31987 r33540 54 54 * @subsection sec_dbg_op_address Addressing modes 55 55 * 56 * - Default is flat. For compat ability '%' also means flat.56 * - Default is flat. For compatibility '%' also means flat. 57 57 * - Segmented addresses are specified selector:offset. 58 58 * - Physical addresses are specified using '%%'. … … 173 173 174 174 /** 175 * Init alizes g_bmOperatorChars.175 * Initializes g_bmOperatorChars. 176 176 */ 177 177 static void dbgcInitOpCharBitMap(void) … … 996 996 } 997 997 else 998 /* plain expression or using unary operators perhaps with par atheses. */998 /* plain expression or using unary operators perhaps with parentheses. */ 999 999 rc = dbgcEvalSubUnary(pDbgc, pszExpr, cchExpr, pResult); 1000 1000 … … 1093 1093 /* 1094 1094 * When quoted we ignore everything but the quotation char. 1095 * We use the REXX way of escaping the quotation char, i.e. double occur ence.1095 * We use the REXX way of escaping the quotation char, i.e. double occurrence. 1096 1096 */ 1097 1097 else if (ch == '\'' || ch == '"' || ch == '`') -
trunk/src/VBox/Debugger/DBGPlugInCommonELF.h
r31530 r33540 25 25 /** @name DBGDiggerCommonParseElf32Mod and DBGDiggerCommonParseElf64Mod flags 26 26 * @{ */ 27 /** Whet er to adjust the symbol values or not. */27 /** Whether to adjust the symbol values or not. */ 28 28 #define DBG_DIGGER_ELF_ADJUST_SYM_VALUE RT_BIT_32(0) 29 29 /** Indicates that we're missing section headers and that -
trunk/src/VBox/Debugger/DBGPlugInCommonELFTmpl.cpp.h
r31530 r33540 156 156 157 157 /* 158 * Validate the symbol table and determin the max section index158 * Validate the symbol table and determine the max section index 159 159 * when DBG_DIGGER_ELF_FUNNY_SHDRS is flagged. 160 160 */ -
trunk/src/VBox/Debugger/VBoxDbgConsole.cpp
r31530 r33540 257 257 258 258 /* 259 * The tab order is from input to output, not the other way around as it is by default.259 * The tab order is from input to output, not the other way around as it is by default. 260 260 */ 261 261 setTabOrder(m_pInput, m_pOutput); -
trunk/src/VBox/Debugger/VBoxDbgGui.h
r31530 r33540 113 113 /** 114 114 * Update the desktop size. 115 * This is called whenever the reference window changes positi tion.115 * This is called whenever the reference window changes position. 116 116 */ 117 117 void updateDesktopSize(); … … 176 176 /** The height of the window we're relative to. */ 177 177 unsigned m_cy; 178 /** The x-coordi anate of the desktop. */178 /** The x-coordinate of the desktop. */ 179 179 int m_xDesktop; 180 /** The y-coordi anate of the desktop. */180 /** The y-coordinate of the desktop. */ 181 181 int m_yDesktop; 182 182 /** The size of the desktop. */ -
trunk/src/VBox/Debugger/VBoxDbgStatsQt4.cpp
r32787 r33540 209 209 * It is vitally important that updateCallback is fed the data in the right 210 210 * order. The code make very definite ASSUMPTIONS about the ordering being 211 * stric ly sorted and taking the slash into account when doing so.211 * strictly sorted and taking the slash into account when doing so. 212 212 * 213 213 * @returns true if we reset the model and it's necessary to set the root index. … … 406 406 407 407 /** 408 * Removes a node from the tree and destroys it and all its de centands.408 * Removes a node from the tree and destroys it and all its descendants. 409 409 * 410 410 * @param pNode The node. … … 412 412 static void removeAndDestroyNode(PDBGGUISTATSNODE pNode); 413 413 414 /** Removes a node from the tree and destroys it and all its de centands414 /** Removes a node from the tree and destroys it and all its descendants 415 415 * performing the required Qt signalling. */ 416 416 void removeAndDestroy(PDBGGUISTATSNODE pNode); … … 429 429 * 430 430 * @param a_pNode The node. 431 * @param a_rString The string to append the stri gified node to.431 * @param a_rString The string to append the stringified node to. 432 432 */ 433 433 static void stringifyNodeNoRecursion(PDBGGUISTATSNODE a_pNode, QString &a_rString); … … 439 439 * 440 440 * @param a_pNode The node. 441 * @param a_rString The string to append the stri gified node to.441 * @param a_rString The string to append the stringified node to. 442 442 */ 443 443 static void stringifyNode(PDBGGUISTATSNODE a_pNode, QString &a_rString); … … 520 520 public: 521 521 522 /** @name Overrid en QAbstractItemModel methods522 /** @name Overridden QAbstractItemModel methods 523 523 * @{ */ 524 524 virtual int columnCount(const QModelIndex &a_rParent) const; … … 1309 1309 return NULL; 1310 1310 1311 /* de cend to children. */1311 /* descend to children. */ 1312 1312 if (pNode->cChildren) 1313 1313 return pNode->papChildren[0]; … … 1354 1354 return NULL; 1355 1355 1356 /* previous sibling's latest de cendant (better expression anyone?). */1356 /* previous sibling's latest descendant (better expression anyone?). */ 1357 1357 if (pNode->iSelf > 0) 1358 1358 { … … 1418 1418 * 1419 1419 * Might consider optimizing insertion at some later point since this 1420 * is a normal occur ance (dynamic statistics in PATM, IOM, MM, ++).1420 * is a normal occurrence (dynamic statistics in PATM, IOM, MM, ++). 1421 1421 */ 1422 1422 Assert(pszName[0] == '/'); … … 1608 1608 if (pNode->cChildren) 1609 1609 { 1610 /* de cend to the first child. */1610 /* descend to the first child. */ 1611 1611 Assert(m_cchUpdateParent + pNode->cchName + 2 < sizeof(m_szUpdateParent)); 1612 1612 memcpy(&m_szUpdateParent[m_cchUpdateParent], pNode->pszName, pNode->cchName); … … 1653 1653 } 1654 1654 1655 /* de cend to a node containing data and finalize the globals. (ASSUMES leaf has data.) */1655 /* descend to a node containing data and finalize the globals. (ASSUMES leaf has data.) */ 1656 1656 if (m_iUpdateChild != UINT32_MAX) 1657 1657 { … … 1807 1807 * Send dataChanged events. 1808 1808 * 1809 * We do this here instead of from the updateCallback because it lesses1809 * We do this here instead of from the updateCallback because it reduces 1810 1810 * the clutter in that method and allow us to emit bulk signals in an 1811 1811 * easier way because we can traverse the tree in a different fashion. -
trunk/src/VBox/Debugger/VBoxDbgStatsQt4.h
r32181 r33540 38 38 * The VM statistics tree view. 39 39 * 40 * A tree represen ation of the STAM statistics.40 * A tree representation of the STAM statistics. 41 41 */ 42 42 class VBoxDbgStatsView : public QTreeView, public VBoxDbgBase -
trunk/src/VBox/Debugger/testcase/tstVBoxDbg.cpp
r32190 r33540 107 107 108 108 /* 109 * Summa y and exit.109 * Summary and exit. 110 110 */ 111 111 if (!cErrors)
Note:
See TracChangeset
for help on using the changeset viewer.