Changeset 33666 in vbox

Timestamp:

Nov 1, 2010 7:21:19 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

67286

Message:

FE/Qt: 4989: Lazy init VM settings dialog: QEventLoop replaced with QMutex + QWaitCondition.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsDialogSpecific.cpp (modified) (10 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsDialogSpecific.cpp

@@ -21 +21 @@
 #include <QStackedWidget>
 #include <QThread>
-#include <QTimer>
+#include <QMutex>
+#include <QWaitCondition>
 
 /* Local includes */
@@ -77 +78 @@
         , m_direction(direction)
         , m_data(data)
+        , m_fConditionDone(false)
         , m_iPageIdWeAreWaitingFor(-1)
         , m_iIdOfHighPriorityPage(-1)
@@ -83 +85 @@
         connect(this, SIGNAL(sigNotifyAboutPageProcessed(int)), this, SLOT(sltHandleProcessedPage(int)), Qt::QueuedConnection);
         connect(this, SIGNAL(sigNotifyAboutPagesProcessed()), this, SLOT(sltHandleProcessedPages()), Qt::QueuedConnection);
-        connect(this, SIGNAL(finished()), this, SLOT(sltDestroySerializer()), Qt::QueuedConnection);
+        connect(this, SIGNAL(finished()), this, SLOT(deleteLater()), Qt::QueuedConnection);
 
         /* Set instance: */
@@ -100 +102 @@
         if (isRunning())
             wait();
-
-        /* If serializer still having event loop running,
-         * we should quit it now: */
-        if (m_eventLoop.isRunning())
-        {
-            m_eventLoop.processEvents();
-            m_eventLoop.quit();
-        }
     }
 
@@ -123 +117 @@
     void waitForPageToBeProcessed(int iPageId)
     {
-        if (!isRunning())
-            return;
         m_iPageIdWeAreWaitingFor = iPageId;
-        m_eventLoop.exec();
+        blockGUIthread();
     }
 
@@ -132 +124 @@
     void waitForPagesToBeProcessed()
     {
-        if (!isRunning())
-            return;
         m_iPageIdWeAreWaitingFor = -1;
-        m_eventLoop.exec();
+        blockGUIthread();
     }
 
@@ -192 +182 @@
                 m_pages[iPageId]->getFromCache();
         }
-        /* If thats the page we are waiting for, unlock the loop,
-         * after all the events of the page which is currently fetching
-         * from cache will be processed: */
-        if (iPageId == m_iPageIdWeAreWaitingFor && m_eventLoop.isRunning())
-            QTimer::singleShot(0, this, SLOT(sltStopEventLoop()));
+        /* If thats the page we are waiting for,
+         * we should flag GUI thread to unlock itself: */
+        if (iPageId == m_iPageIdWeAreWaitingFor && !m_fConditionDone)
+            m_fConditionDone = true;
     }
 
@@ -202 +191 @@
     void sltHandleProcessedPages()
     {
-        /* If all the pages were processed, unlock the loop,
-         * after all the events of the last page will be processed: */
-        if (m_eventLoop.isRunning())
-            QTimer::singleShot(0, this, SLOT(sltStopEventLoop()));
-    }
-
-    /* Slot to destroy serializer: */
-    void sltDestroySerializer()
-    {
-        /* If event loop is still running,
-         * we should try to destroy serializer only on next iteration: */
-        if (m_eventLoop.isRunning())
-            QTimer::singleShot(0, this, SLOT(sltDestroySerializer()));
-        /* Else really make a request to destroy serializer: */
-        else
-            deleteLater();
-    }
-
-    /* Slot to stop event loop: */
-    void sltStopEventLoop()
-    {
-        /* If event loop is still running, we should stop it: */
-        if (m_eventLoop.isRunning())
-        {
-            m_eventLoop.processEvents();
-            m_eventLoop.quit();
-            m_eventLoop.processEvents();
-        }
+        /* We should flag GUI thread to unlock itself: */
+        if (!m_fConditionDone)
+            m_fConditionDone = true;
     }
 
 protected:
+
+    /* GUI thread locker: */
+    void blockGUIthread()
+    {
+        m_fConditionDone = false;
+        while (!m_fConditionDone)
+        {
+            /* Lock mutex initially: */
+            m_mutex.lock();
+            /* Perform idle-processing every 100ms,
+             * and waiting for direct wake up signal: */
+            m_condition.wait(&m_mutex, 100);
+            /* Process queued signals posted to GUI thread: */
+            qApp->processEvents();
+            /* Unlock mutex finally: */
+            m_mutex.unlock();
+        }
+    }
 
     /* Settings processor: */
@@ -257 +239 @@
             /* Remember what page was processed: */
             pPage->setProcessed(true);
+            /* Remove processed page from our map: */
+            pages.remove(pPage->id());
             /* Notify listeners about page was processed: */
             emit sigNotifyAboutPageProcessed(pPage->id());
-            /* Remove processed page from our map: */
-            pages.remove(pPage->id());
+            /* Try to wake up GUI thread, but
+             * it can be busy idle-processing for loaded pages: */
+            if (!m_fConditionDone)
+                m_condition.wakeAll();
         }
         /* Notify listeners about all pages were processed: */
         emit sigNotifyAboutPagesProcessed();
+        /* Try to wake up GUI thread, but
+         * it can be busy idle-processing loaded pages: */
+        if (!m_fConditionDone)
+            m_condition.wakeAll();
     }
 
@@ -269 +259 @@
     UISettingsSerializeDirection m_direction;
     QVariant m_data;
-    QEventLoop m_eventLoop;
     UISettingsPageMap m_pages;
+    bool m_fConditionDone;
     int m_iPageIdWeAreWaitingFor;
     int m_iIdOfHighPriorityPage;
+    QMutex m_mutex;
+    QWaitCondition m_condition;
     static UISettingsSerializer *m_pInstance;
 };