Changeset 33709 in vbox for trunk/src/VBox

Timestamp:

Nov 2, 2010 7:15:26 PM (14 years ago)

Author:

vboxsync

Message:

Main/Machine: Reject any attempt to open a VM config with the same UUID as an already existing VM, e.g. caused by an attempt to open the config of an already known VM again. Much better to let people know what's going on instead of failing with Medium object conflicts (and without a human readable error message).

File:

• trunk/src/VBox/Main/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -396 +396 @@
                 mData->pMachineConfigFile = new settings::MachineConfigFile(&mData->m_strConfigFileFull);
 
+                // reject VM UUID duplicates, they can happen if someone
+                // tries to register an already known VM config again
+                if (aParent->findMachine(mData->pMachineConfigFile->uuid,
+                                         true /* fPermitInaccessible */,
+                                         false /* aDoSetError */,
+                                         NULL) != VBOX_E_OBJECT_NOT_FOUND)
+                {
+                    throw setError(E_FAIL,
+                                   tr("Trying to open a VM config '%s' which has the same UUID as an existing virtual machine"),
+                                   mData->m_strConfigFile.c_str());
+                }
+
                 // use UUID from machine config
                 unconst(mData->mUuid) = mData->pMachineConfigFile->uuid;