Changeset 33840 in vbox for trunk/src/VBox/VMM

Timestamp:

Nov 8, 2010 1:44:38 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

67486

Message:

AsyncCompletion: Alignment assertions and remove a bit of unused code

Location:

trunk/src/VBox/VMM

Files:

• PDMAsyncCompletion.cpp (modified) (2 diffs)
• PDMAsyncCompletionInternal.h (modified) (4 diffs)

trunk/src/VBox/VMM/PDMAsyncCompletion.cpp

@@ -1067 +1067 @@
     if (RT_LIKELY(pTask))
     {
-        /* Get ID of the task. */
-        pTask->uTaskId   = ASMAtomicIncU32(&pEndpoint->uTaskIdNext);
-
         /* Initialize common parts. */
         pTask->pvUser    = pvUser;
@@ -1219 +1216 @@
             pEndpoint->pPrev             = NULL;
             pEndpoint->pEpClass          = pEndpointClass;
-            pEndpoint->uTaskIdNext       = 0;
-            pEndpoint->fTaskIdWraparound = false;
             pEndpoint->pTemplate         = pTemplate;
             pEndpoint->pszUri            = RTStrDup(pszFilename);

trunk/src/VBox/VMM/PDMAsyncCompletionInternal.h

@@ -200 +200 @@
     /** Pointer to the class this endpoint belongs to. */
     R3PTRTYPE(PPDMASYNCCOMPLETIONEPCLASS)       pEpClass;
-    /** ID of the next task to ensure consistency. */
-    volatile uint32_t                           uTaskIdNext;
-    /** Flag whether a wraparound occurred for the ID counter. */
-    bool                                        fTaskIdWraparound;
     /** Template associated with this endpoint. */
     PPDMASYNCCOMPLETIONTEMPLATE                 pTemplate;
@@ -213 +209 @@
     volatile PPDMACBWMGR                        pBwMgr;
 #ifdef VBOX_WITH_STATISTICS
+    uint32_t                                    u32Alignment;
     STAMCOUNTER                                 StatTaskRunTimesNs[10];
     STAMCOUNTER                                 StatTaskRunTimesMicroSec[10];
@@ -225 +222 @@
 #endif
 } PDMASYNCCOMPLETIONENDPOINT;
+#ifdef VBOX_WITH_STATISTICS
+AssertCompileMemberAlignment(PDMASYNCCOMPLETIONENDPOINT, StatTaskRunTimesNs, sizeof(uint64_t));
+#endif
 
 /**
@@ -242 +242 @@
     /** Opaque user data for this task. */
     void                                   *pvUser;
-    /** Task id. */
-    uint32_t                                uTaskId;
     /** Start timestamp. */
     uint64_t                                tsNsStart;