Changeset 33923 in vbox

Timestamp:

Nov 9, 2010 8:22:17 PM (14 years ago)

Author:

vboxsync

Message:

FE/Qt: Some rework for r67571 (GUI part).

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine

Files:

• UIMachineSettingsStorage.cpp (modified) (5 diffs)
• UIMachineSettingsStorage.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp

@@ -902 +902 @@
     else
         return QModelIndex();
-}
-
-KChipsetType StorageModel::getChipsetType() const
-{
-#if 0
-    CMachine mach = vboxGlobal().virtualBox().FindMachine(mRootItem->machineId());
-    Assert(!mach.isNull());
-    return mach.GetChipsetType();
-#else
-    return KChipsetType_PIIX3;
-#endif
 }
 
@@ -1034 +1023 @@
         {
             return static_cast <RootItem*> (mRootItem)->childCount (KStorageBus_IDE) <
-                    vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (getChipsetType(), KStorageBus_IDE);
+                    vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (chipsetType(), KStorageBus_IDE);
         }
         case R_IsMoreSATAControllersPossible:
         {
             return static_cast <RootItem*> (mRootItem)->childCount (KStorageBus_SATA) <
-                   vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (getChipsetType(), KStorageBus_SATA);
+                   vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (chipsetType(), KStorageBus_SATA);
         }
         case R_IsMoreSCSIControllersPossible:
         {
             return static_cast <RootItem*> (mRootItem)->childCount (KStorageBus_SCSI) <
-                   vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (getChipsetType(), KStorageBus_SCSI);
+                   vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (chipsetType(), KStorageBus_SCSI);
         }
         case R_IsMoreFloppyControllersPossible:
         {
             return static_cast <RootItem*> (mRootItem)->childCount (KStorageBus_Floppy) <
-                   vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (getChipsetType(), KStorageBus_Floppy);
+                   vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (chipsetType(), KStorageBus_Floppy);
         }
         case R_IsMoreSASControllersPossible:
         {
             return static_cast <RootItem*> (mRootItem)->childCount (KStorageBus_SAS) <
-                   vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (getChipsetType(), KStorageBus_SAS);
+                   vboxGlobal().virtualBox().GetSystemProperties().GetMaxInstancesOfStorageBus (chipsetType(), KStorageBus_SAS);
         }
         case R_IsMoreAttachmentsPossible:
@@ -1522 +1511 @@
     return !aIndex.isValid() ? QAbstractItemModel::flags (aIndex) :
            Qt::ItemIsEnabled | Qt::ItemIsSelectable;
+}
+
+KChipsetType StorageModel::chipsetType() const
+{
+    CMachine machine = vboxGlobal().virtualBox().FindMachine(mRootItem->machineId());
+    Assert(!machine.isNull());
+    return machine.GetChipsetType();
 }
 
@@ -1788 +1784 @@
     connect (mCbPassthrough, SIGNAL (stateChanged (int)), this, SLOT (setInformation()));
 
-    /* Update actions */
-    updateActionsState();
-
     /* Applying language settings */
     retranslateUi();
@@ -1880 +1873 @@
     if (mStorageModel->rowCount(mStorageModel->root()) > 0)
         mTwStorageTree->setCurrentIndex(mStorageModel->index(0, 0, mStorageModel->root()));
+
+    /* Update actions: */
+    updateActionsState();
 
     /* Revalidate if possible: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.h

@@ -502 +502 @@
     Qt::ItemFlags flags (const QModelIndex &aIndex) const;
 
+    KChipsetType chipsetType() const;
+
     AbstractItem *mRootItem;
 
@@ -511 +513 @@
 
     ToolTipType mToolTipType;
-
-    KChipsetType getChipsetType() const;
 };
 Q_DECLARE_METATYPE (StorageModel::ToolTipType);