Changeset 34128 in vbox for trunk

Timestamp:

Nov 16, 2010 5:28:34 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

67840

Message:

mp-freebsd.cpp: r=bird: RTStrPrintf does not return an IPRT status code. Unnecessary variable initialization is confusing.

File:

• trunk/src/VBox/Runtime/r3/freebsd/mp-freebsd.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/freebsd/mp-freebsd.cpp

@@ -84 +84 @@
 RTDECL(bool) RTMpIsCpuOnline(RTCPUID idCpu)
 {
-    int rc = VINF_SUCCESS;
-    char szName[32];
-    char szDriver[10];
-    size_t cbDriver = sizeof(szDriver);
-
     /*
-     * FreeBSD doesn't support CPU hotplugging
-     * so every CPU which appears in the tree is also online.
+     * FreeBSD doesn't support CPU hotplugging so every CPU which appears
+     * in the tree is also online.
      */
-    memset(szDriver, 0, sizeof(szDriver));
-    memset(szName, 0, sizeof(szName));
-
-    rc = RTStrPrintf(szName, sizeof(szName), "dev.cpu.%d.%%driver", (int)idCpu);
-    if (RT_SUCCESS(rc))
-    {
-        int rcBsd = sysctlbyname(szName, szDriver, &cbDriver, NULL, NULL);
-        if (rcBsd == 0)
-            return true;
-    }
+    char    szName[40];
+    RTStrPrintf(szName, sizeof(szName), "dev.cpu.%d.%%driver", (int)idCpu);
+
+    char    szDriver[10];
+    size_t  cbDriver = sizeof(szDriver);
+    RT_ZERO(szDevice);                  /* this shouldn't be necessary. */
+    int rcBsd = sysctlbyname(szName, szDriver, &cbDriver, NULL, NULL);
+    if (rcBsd == 0)
+        return true;
 
     return false;