Changeset 34197 in vbox for trunk/src

Timestamp:

Nov 19, 2010 1:18:50 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

67937

Message:

dbgfR3CoreWrite: Must use PGMPhysSimpleReadGCPhys because PGMPhysRead has sideffects on read access handled pages and runs into trouble with MMIO.

File:

• trunk/src/VBox/VMM/DBGFCoreWrite.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/DBGFCoreWrite.cpp

@@ -448 +448 @@
         /*
          * Write page-by-page of this memory range.
+         *
+         * The read function may fail on MMIO ranges, we write these as zero
+         * pages for now (would be nice to have the VGA bits there though).
          */
         uint64_t cbMemRange  = GCPhysEnd - GCPhysStart + 1;
@@ -454 +457 @@
         {
             uint8_t abPage[PAGE_SIZE];
-            rc = PGMPhysRead(pVM, GCPhysStart + (iPage << PAGE_SHIFT), abPage, sizeof(abPage));
+            rc = PGMPhysSimpleReadGCPhys(pVM, abPage, GCPhysStart + (iPage << PAGE_SHIFT),  sizeof(abPage));
             if (RT_FAILURE(rc))
             {
-                /*
-                 * For some reason this failed, write out a zero page instead.
-                 */
-                LogRel((DBGFLOG_NAME ": PGMPhysRead failed for iRange=%u iPage=%u. rc=%Rrc. Ignoring...\n", iRange, iPage, rc));
+                if (rc != VERR_PGM_PHYS_PAGE_RESERVED)
+                    LogRel((DBGFLOG_NAME ": PGMPhysRead failed for iRange=%u iPage=%u. rc=%Rrc. Ignoring...\n", iRange, iPage, rc));
                 RT_ZERO(abPage);
             }