Changeset 34250 in vbox for trunk/src/VBox/Frontends

Timestamp:

Nov 22, 2010 3:21:57 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

67998

Message:

VBoxManageGuestCtrl.cpp: r=bird: Shouldn't --mode be octal? Please fix. Bunch of other todos that needs addressing.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (10 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -281 +281 @@
     args.push_back(Bstr(Utf8Cmd).raw());
 
+/** @todo r=bird: Use RTGetOpt here, no new code using strcmp-if-switching! */
     /* Iterate through all possible commands (if available). */
     bool usageOK = true;
@@ -611 +612 @@
  * @param   pList               Copy list used for insertion.
  */
+/** @todo r=bird: static? */
 int ctrlCopyDirectoryEntryAppend(const char *pszFileSource, const char *pszFileDest,
                                  PRTLISTNODE pList)
@@ -652 +654 @@
  * @param   pList               Pointer to the object list to use.
  */
+/** @todo r=bird: static? */
 int ctrlCopyDirectoryRead(const char *pszRootDir, const char *pszSubDir,
                           const char *pszFilter, const char *pszDest,
@@ -794 +797 @@
  * @param   pList               Where to store the object list.
  */
+/** @todo r=bird: static? */
 int ctrlCopyInit(const char *pszSource, const char *pszDest, uint32_t uFlags,
                  uint32_t *pcObjects, PRTLISTNODE pList)
@@ -919 +923 @@
  * Destroys a copy list.
  */
+/** @todo r=bird: static? */
 void ctrlCopyDestroy(PRTLISTNODE pList)
 {
@@ -955 +960 @@
  * @param   uFlags          Copy flags.
  */
+/** @todo r=bird: static? */
 int ctrlCopyFileToGuest(IGuest *pGuest, const char *pszSource, const char *pszDest,
                         const char *pszUserName, const char *pszPassword,
@@ -1044 +1050 @@
     bool fCopyRecursive = false;
     bool fDryRun = false;
+/** @todo r=bird: Use RTGetOpt here, no new code using strcmp-if-switching!  */
 
     /* Iterate through all possible commands (if available). */
@@ -1218 +1225 @@
     uint32_t uMode = 0;
     bool fVerbose = false;
+/** @todo r=bird: Use RTGetOpt here, no new code using strcmp-if-switching!  */
 
     /* Iterate through all possible commands (if available). */
@@ -1253 +1261 @@
                  || !strcmp(a->argv[i], "-m"))
         {
+            /** @todo r=bird: the mode is octal, isn't it? */
             if (i + 1 >= a->argc
                 || RTStrToUInt32Full(a->argv[i + 1], 10, &uMode) != VINF_SUCCESS)
@@ -1373 +1382 @@
     bool fVerbose = false;
 
+/** @todo r=bird: Use RTGetOpt here, no new code using strcmp-if-switching!  */
     /* Iterate through all possible commands (if available). */
     bool usageOK = true;