Changeset 34321 in vbox

Timestamp:

Nov 24, 2010 1:35:10 PM (14 years ago)

Author:

vboxsync

Message:

SUPDrv.c: Set the windows timer granularity to 1024, 1000, 512 or 500 HZ (higher is prefered) while VMs are running (tied to GIP actually).

File:

• trunk/src/VBox/HostDrivers/Support/SUPDrv.c (modified) (6 diffs)

trunk/src/VBox/HostDrivers/Support/SUPDrv.c

@@ -460 +460 @@
                     {
                         pDevExt->u32Cookie = BIRD;  /** @todo make this random? */
-                        pDevExt->cbSession = cbSession;
+                        pDevExt->cbSession = (uint32_t)cbSession;
 
                         /*
@@ -3344 +3344 @@
                 PSUPGLOBALINFOPAGE pGipR0 = pDevExt->pGip;
                 uint64_t u64NanoTS;
+                uint32_t u32SystemResolution;
                 unsigned i;
 
                 LogFlow(("SUPR0GipMap: Resumes GIP updating\n"));
+
+                /*
+                 * Try bump up the system timer resolution.
+                 * The more interrupts the better...
+                 */
+                if (   RT_SUCCESS_NP(RTTimerRequestSystemGranularity(  976563 /* 1024 HZ */, &u32SystemResolution))
+                    || RT_SUCCESS_NP(RTTimerRequestSystemGranularity( 1000000 /* 1000 HZ */, &u32SystemResolution))
+                    || RT_SUCCESS_NP(RTTimerRequestSystemGranularity( 1953125 /*  512 HZ */, &u32SystemResolution))
+                    || RT_SUCCESS_NP(RTTimerRequestSystemGranularity( 2000000 /*  500 HZ */, &u32SystemResolution))
+                   )
+                {
+                    Assert(RTTimerGetSystemGranularity() <= u32SystemResolution);
+                    pDevExt->u32SystemTimerGranularityGrant = u32SystemResolution;
+                }
 
                 if (pGipR0->aCPUs[0].u32TransactionId != 2 /* not the first time */)
@@ -3450 +3465 @@
             rc = RTTimerStop(pDevExt->pGipTimer); AssertRC(rc); rc = VINF_SUCCESS;
 #endif
+
+            if (pDevExt->u32SystemTimerGranularityGrant)
+            {
+                int rc2 = RTTimerReleaseSystemGranularity(pDevExt->u32SystemTimerGranularityGrant); AssertRC(rc);
+                pDevExt->u32SystemTimerGranularityGrant = 0;
+            }
         }
     }
@@ -4867 +4888 @@
     HCPhysGip = RTR0MemObjGetPagePhysAddr(pDevExt->GipMemObj, 0); Assert(HCPhysGip != NIL_RTHCPHYS);
 
-#if 0 /** @todo Disabled this as we didn't used to do it before and causes unnecessary stress on laptops.
-       * It only applies to Windows and should probably revisited later, if possible made part of the
-       * timer code (return min granularity in RTTimerGetSystemGranularity and set it in RTTimerStart). */
-    /*
-     * Try bump up the system timer resolution.
-     * The more interrupts the better...
-     */
-    if (   RT_SUCCESS(RTTimerRequestSystemGranularity(  488281 /* 2048 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity(  500000 /* 2000 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity(  976563 /* 1024 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity( 1000000 /* 1000 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity( 1953125 /*  512 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity( 2000000 /*  500 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity( 3906250 /*  256 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity( 4000000 /*  250 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity( 7812500 /*  128 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity(10000000 /*  100 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity(15625000 /*   64 HZ */, &u32SystemResolution))
-        || RT_SUCCESS(RTTimerRequestSystemGranularity(31250000 /*   32 HZ */, &u32SystemResolution))
-       )
-    {
-        Assert(RTTimerGetSystemGranularity() <= u32SystemResolution);
-        pDevExt->u32SystemTimerGranularityGrant = u32SystemResolution;
-    }
-#endif
-
     /*
      * Find a reasonable update interval and initialize the structure.
@@ -4983 +4978 @@
 
     /*
-     * Finally, release the system timer resolution request if one succeeded.
+     * Finally, make sure we've release the system timer resolution request
+     * if one actually succeeded and is still pending.
      */
     if (pDevExt->u32SystemTimerGranularityGrant)
@@ -5286 +5282 @@
             = pGip->aCPUs[i].au32TSCHistory[6]
             = pGip->aCPUs[i].au32TSCHistory[7]
-            = /*pGip->aCPUs[i].u64CpuHz*/ _4G / uUpdateHz;
+            = /*pGip->aCPUs[i].u64CpuHz*/ (uint32_t)(_4G / uUpdateHz);
     }