Changeset 3466 in vbox for trunk/src/VBox/Additions/common

Timestamp:

Jul 5, 2007 1:23:14 PM (18 years ago)

Author:

vboxsync

Message:

Wrong locking for read-only memory in Windows guests.

Location:

trunk/src/VBox/Additions/common/VBoxGuestLib

Files:

• HGCMInternal.cpp (modified) (1 diff)
• SysHlp.cpp (modified) (2 diffs)
• SysHlp.h (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxGuestLib/HGCMInternal.cpp

@@ -179 +179 @@
                        These kind of problems actually applies to some patched linux kernels too, including older
                        fedora releases. (The patch is the infamous 4G/4G patch, aka 4g4g, by Ingo Molnar.) */
-                    rc = vbglLockLinear (&apvCtx[iParm], (void *)pParm->u.Pointer.u.linearAddr, pParm->u.Pointer.size);
+                    rc = vbglLockLinear (&apvCtx[iParm], (void *)pParm->u.Pointer.u.linearAddr, pParm->u.Pointer.size, (pParm->type == VMMDevHGCMParmType_LinAddr_In) ? false : true /* write access */);
                     
                     if (VBOX_FAILURE (rc))

trunk/src/VBox/Additions/common/VBoxGuestLib/SysHlp.cpp

@@ -32 +32 @@
 
 
-int vbglLockLinear (void **ppvCtx, void *pv, uint32_t u32Size)
+int vbglLockLinear (void **ppvCtx, void *pv, uint32_t u32Size, bool fWriteAccess)
 {
     int rc = VINF_SUCCESS;
@@ -49 +49 @@
             MmProbeAndLockPages (pMdl,
                                  KernelMode,
-                                 IoModifyAccess);
+                                 (fWriteAccess) ? IoModifyAccess : IoReadAccess);
                                  
             *ppvCtx = pMdl;

trunk/src/VBox/Additions/common/VBoxGuestLib/SysHlp.h

@@ -61 +61 @@
 } VBGLDRIVER;
 
-int vbglLockLinear (void **ppvCtx, void *pv, uint32_t u32Size);
+int vbglLockLinear (void **ppvCtx, void *pv, uint32_t u32Size, bool fWriteAccess);
 void vbglUnlockLinear (void *pvCtx, void *pv, uint32_t u32Size);