Changeset 34825 in vbox

Timestamp:

Dec 8, 2010 11:02:22 AM (14 years ago)

Author:

vboxsync

Message:

GuestControl/service: Don't try to deliver too big messages to the client forever.

File:

• trunk/src/VBox/HostServices/GuestControl/service.cpp (modified) (2 diffs)

trunk/src/VBox/HostServices/GuestControl/service.cpp

@@ -133 +133 @@
       * from the HGCM parameters. */
     uint32_t mContextID;
+    /** How many times the host service has tried to deliver this
+     *  command to the guest. */
+    uint32_t mTries;
     /** Dynamic structure for holding the HGCM parms */
     VBOXGUESTCTRPARAMBUFFER mParmBuf;
 
     /** The standard constructor. */
-    HostCmd() : mContextID(0) {}
+    HostCmd() : mContextID(0), mTries(0) {}
 };
 /** The host cmd list + iterator type */
@@ -627 +630 @@
              mHostCmds.pop_front();
          }
+         else if (rc == VERR_BUFFER_OVERFLOW)
+         {
+             /* If the client understood the message but supplied too little buffer space
+              * don't send this message again and drop it after 3 unsuccessful attempts.
+              * The host then should take care of next actions (maybe retry it with a smaller buffer). */
+             if (++curCmd.mTries >= 3)
+             {
+                 paramBufferFree(&curCmd.mParmBuf);
+                 mHostCmds.pop_front();
+             }
+         }
     }
     return rc;