Changeset 35035 in vbox for trunk/src/VBox/HostServices/GuestControl

Timestamp:

Dec 13, 2010 4:49:53 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

68864

Message:

HostServices/GuestControl: Better client count checks.

File:

• trunk/src/VBox/HostServices/GuestControl/service.cpp (modified) (4 diffs)

trunk/src/VBox/HostServices/GuestControl/service.cpp

@@ -171 +171 @@
     ClientContextsList mClientContextsList;
     /** Number of connected clients. */
-    int32_t mNumClients;
+    uint32_t mNumClients;
 public:
     explicit Service(PVBOXHGCMSVCHELPERS pHelpers)
@@ -462 +462 @@
 {
     LogFlowFunc(("New client (%ld) connected\n", u32ClientID));
-    mNumClients++;
+    if (mNumClients < UINT32_MAX)
+        mNumClients++;
+    else
+        AssertMsgFailed(("Max. number of clients reached\n"));
     return VINF_SUCCESS;
 }
@@ -478 +481 @@
 {
     LogFlowFunc(("Client (%ld) disconnected\n", u32ClientID));
+    Assert(mNumClients > 0);
     mNumClients--;
-    Assert(mNumClients >= 0);
 
     /*
@@ -760 +763 @@
      * the guest is not running/system is messed up somehow.
      */
-    if (mNumClients <= 0)
+    if (mNumClients == 0)
         return VERR_NOT_FOUND;