Changeset 35139 in vbox

Timestamp:

Dec 15, 2010 3:13:43 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

68976

Message:

Main: use VirtualBox::saveRegistries() instead of plain VirtualBox::saveSettings() on media property changes to make sure the correct registry gets saved

Location:

trunk/src/VBox/Main

Files:

• MediumImpl.cpp (modified) (7 diffs)
• VirtualBoxImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MediumImpl.cpp

@@ -1747 +1747 @@
     m->type = aType;
 
-    // save the global settings; for that we should hold only the VirtualBox lock
+    // save the settings
+    GuidList llRegistriesThatNeedSaving;
+    addToRegistryIDList(llRegistriesThatNeedSaving);
     mlock.release();
-    AutoWriteLock alock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
-    HRESULT rc = m->pVirtualBox->saveSettings();
+    HRESULT rc = m->pVirtualBox->saveRegistries(llRegistriesThatNeedSaving);
 
     return rc;
@@ -1870 +1871 @@
                         m->strLocationFull.c_str());
 
+    HRESULT rc = S_OK;
+
     if (m->autoReset != !!aAutoReset)
     {
         m->autoReset = !!aAutoReset;
 
-        // save the global settings; for that we should hold only the VirtualBox lock
+        // save the settings
+        GuidList llRegistriesThatNeedSaving;
+        addToRegistryIDList(llRegistriesThatNeedSaving);
         mlock.release();
-        AutoWriteLock alock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
-        return m->pVirtualBox->saveSettings();
-    }
-
-    return S_OK;
-}
+        rc = m->pVirtualBox->saveRegistries(llRegistriesThatNeedSaving);
+    }
+
+    return rc;
+}
+
 STDMETHODIMP Medium::COMGETTER(LastAccessError)(BSTR *aLastAccessError)
 {
@@ -2300 +2305 @@
     it->second = aValue;
 
-    // save the global settings; for that we should hold only the VirtualBox lock
+    // save the settings
+    GuidList llRegistriesThatNeedSaving;
+    addToRegistryIDList(llRegistriesThatNeedSaving);
     mlock.release();
-    AutoWriteLock alock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
-    HRESULT rc = m->pVirtualBox->saveSettings();
+    HRESULT rc = m->pVirtualBox->saveRegistries(llRegistriesThatNeedSaving);
 
     return rc;
@@ -2377 +2383 @@
     }
 
+    // save the settings
+    GuidList llRegistriesThatNeedSaving;
+    addToRegistryIDList(llRegistriesThatNeedSaving);
     mlock.release();
-
-    // saveSettings needs vbox lock
-    AutoWriteLock alock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
-    HRESULT rc = m->pVirtualBox->saveSettings();
+    HRESULT rc = m->pVirtualBox->saveRegistries(llRegistriesThatNeedSaving);
 
     return rc;
@@ -6604 +6610 @@
     {
         // in asynchronous mode, save settings now
-        // for that we should hold only the VirtualBox lock
-        AutoWriteLock vboxlock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
-        m->pVirtualBox->saveSettings();
+        GuidList llRegistriesThatNeedSaving;
+        addToRegistryIDList(llRegistriesThatNeedSaving);
+        rc = m->pVirtualBox->saveRegistries(llRegistriesThatNeedSaving);
     }
     else
@@ -6869 +6875 @@
     // now, at the end of this task (always asynchronous), save the settings
     {
-        AutoWriteLock vboxlock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
-        m->pVirtualBox->saveSettings();
+        // save the settings
+        GuidList llRegistriesThatNeedSaving;
+        addToRegistryIDList(llRegistriesThatNeedSaving);
+        rc = m->pVirtualBox->saveRegistries(llRegistriesThatNeedSaving);
     }
 
@@ -7623 +7631 @@
     // now, at the end of this task (always asynchronous), save the settings
     {
-        AutoWriteLock vboxlock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
-        m->pVirtualBox->saveSettings();
+        // save the settings
+        GuidList llRegistriesThatNeedSaving;
+        addToRegistryIDList(llRegistriesThatNeedSaving);
+        rc = m->pVirtualBox->saveRegistries(llRegistriesThatNeedSaving);
     }
 

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -3732 +3732 @@
 }
 
+/**
+ * Saves all settings files according to the given list of UUIDs, which are
+ * either machine IDs (in which case Machine::saveSettings is invoked) or
+ * the global registry UUID (in which case VirtualBox::saveSettings is invoked).
+ *
+ * This locks machines and the VirtualBox object as necessary, so better not
+ * hold any locks before calling this.
+ *
+ * @param llRegistriesThatNeedSaving
+ * @return
+ */
 HRESULT VirtualBox::saveRegistries(const GuidList &llRegistriesThatNeedSaving)
 {