Changeset 35184 in vbox for trunk/include/VBox/ExtPack

Timestamp:

Dec 16, 2010 2:00:55 PM (14 years ago)

Author:

vboxsync

Message:

ExtPack: Changed the installed callback so that it can report back error info and trigger an immediate uninstall ifhoost incompatibilities are found.

File:

• trunk/include/VBox/ExtPack/ExtPack.h (modified) (4 diffs)

trunk/include/VBox/ExtPack/ExtPack.h

@@ -185 +185 @@
      * This is called in the context of the per-user service (VBoxSVC).
      *
+     * @returns VBox status code.
+     * @retval  VERR_EXTPACK_UNSUPPORTED_HOST_UNINSTALL if the extension pack
+     *          requires some different host version or a prerequisite is
+     *          missing from the host.  Automatic uninstall will be attempted.
+     *          Must set error info.
+     *
      * @param   pThis       Pointer to this structure.
      * @param   pVirtualBox The VirtualBox interface.
-     */
-    DECLCALLBACKMEMBER(void, pfnInstalled)(PCVBOXEXTPACKREG pThis, VBOXEXTPACK_IF_CS(IVirtualBox) *pVirtualBox);
+     * @param   pErrInfo    Where to return extended error information.
+     */
+    DECLCALLBACKMEMBER(int, pfnInstalled)(PCVBOXEXTPACKREG pThis, VBOXEXTPACK_IF_CS(IVirtualBox) *pVirtualBox,
+                                          PRTERRINFO pErrInfo);
 
     /**
@@ -198 +206 @@
      * @param   pThis       Pointer to this structure.
      * @param   pVirtualBox The VirtualBox interface.
+     *
      * @todo    This is currently called holding locks making pVirtualBox
      *          relatively unusable.
@@ -319 +328 @@
  *                          be valid and unchanged until the module is unloaded
  *                          (i.e. use some static const data for it).
- * @param   pszErr          Error message buffer for explaining any failure.
- * @param   cbErr           The size of the error message buffer.
- */
-typedef DECLCALLBACK(int) FNVBOXEXTPACKREGISTER(PCVBOXEXTPACKHLP pHlp, PCVBOXEXTPACKREG *ppReg, char *pszErr, size_t cbErr);
+ * @param   pErrInfo        Where to return extended error information.
+ */
+typedef DECLCALLBACK(int) FNVBOXEXTPACKREGISTER(PCVBOXEXTPACKHLP pHlp, PCVBOXEXTPACKREG *ppReg, PRTERRINFO pErrInfo);
 /** Pointer to a FNVBOXEXTPACKREGISTER. */
 typedef FNVBOXEXTPACKREGISTER *PFNVBOXEXTPACKREGISTER;
@@ -339 +347 @@
 #define VBOXEXTPACK_IS_VER_COMPAT(u32Provider, u32User) \
     (    VBOXEXTPACK_IS_MAJOR_VER_EQUAL(u32Provider, u32User) \
-      && RT_LOWORD(u32Provider) >= RT_LOWORD(u32User) )
+      && (int32_t)RT_LOWORD(u32Provider) >= (int32_t)RT_LOWORD(u32User) ) /* stupid casts to shut up gcc */
 
 /**