Changeset 35241 in vbox

Timestamp:

Dec 20, 2010 1:14:55 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

69088

Message:

Frontends/VBoxManage: more paranoid error handling for finding media in storageattach

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageStorageController.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageStorageController.cpp

@@ -397 +397 @@
                         rc = findMedium(a, pszMedium, deviceType, true /* fSilent */,
                                         pExistingMedium);
-                        if (pExistingMedium)
+                        if (SUCCEEDED(rc) && pExistingMedium)
                         {
                             if (    (deviceType == DeviceType_DVD)
@@ -545 +545 @@
                 rc = findOrOpenMedium(a, pszMedium, devTypeRequested,
                                       pMedium2Mount, NULL);
-                if (!pMedium2Mount)
+                if (FAILED(rc) || !pMedium2Mount)
                     throw Utf8StrFmt("Invalid UUID or filename \"%s\"", pszMedium);
             }